Fix all lint errors

Author: tbranyen

lib/repository.js

@@ -1,29 +1,22 @@
 var git = require("../");
-var util = require("./util");
-var Refs = require("./reference");
 var normalizeOid = require("./util/normalize_oid");
 
+var TreeBuilder = git.Treebuilder;
 var Commit = git.Commit;
 var Revwalk = git.Revwalk;
-var Repo = git.Repository;
+var Repository = git.Repository;
 var Blob = git.Blob;
 var Tree = git.Tree;
 var Reference = git.Reference;
 
-// Backwards compatibility.
-Object.defineProperty(git, "Repo", {
-  value: Repo,
-  enumerable: false
-});
-
 /**
  * Look up a branch"s most recent commit.
  *
  * @param {String} name Branch name, e.g. "master"
  * @param {Function} callback
  * @return {Branch}
  */
-Repo.prototype.getBranch = function(name, callback) {
+Repository.prototype.getBranch = function(name, callback) {
   var repository = this;
 
   return this.getReference("refs/heads/" + name).then(function(reference) {
@@ -44,14 +37,18 @@ Repo.prototype.getBranch = function(name, callback) {
  * @param {Function} callback
  * @return {Reference}
  */
-Repo.prototype.getReference = function(name, callback) {
+Repository.prototype.getReference = function(name, callback) {
   var repository = this;
 
   return Reference.lookup(this, name).then(function(reference) {
     if (reference.type() == Reference.Type.Symbolic) {
       return reference.resolve(function (error, reference) {
-        if (error) return callback(error);
+        if (error) {
+          return callback(error);
+        }
+
         reference.repo = repository;
+
         if (callback) {
           callback(null, reference);
         }
@@ -74,7 +71,7 @@ Repo.prototype.getReference = function(name, callback) {
  * @param {Function} callback
  * @return {Commit}
  */
-Repo.prototype.getCommit = function(oid, callback) {
+Repository.prototype.getCommit = function(oid, callback) {
   oid = normalizeOid(oid);
 
   var repository = this;
@@ -97,7 +94,7 @@ Repo.prototype.getCommit = function(oid, callback) {
  * @param {Function} callback
  * @return {Blob}
  */
-Repo.prototype.getBlob = function(oid, callback) {
+Repository.prototype.getBlob = function(oid, callback) {
   oid = normalizeOid(oid);
 
   var repository = this;
@@ -120,7 +117,7 @@ Repo.prototype.getBlob = function(oid, callback) {
  * @param {Function} callback
  * @return {Tree}
  */
-Repo.prototype.getTree = function(oid, callback) {
+Repository.prototype.getTree = function(oid, callback) {
   oid = normalizeOid(oid);
 
   var repository = this;
@@ -144,7 +141,7 @@ Repo.prototype.getTree = function(oid, callback) {
  * @param {Function} callback
  * @return {Tag}
  */
-Repo.prototype.getTag = function(oid, callback) {
+Repository.prototype.getTag = function(oid, callback) {
   oid = normalizeOid(oid);
 
   var repository = this;
@@ -161,14 +158,14 @@ Repo.prototype.getTag = function(oid, callback) {
 };
 
 /**
- * Instantiate a new revision walker for browsing the Repo"s history.
+ * Instantiate a new revision walker for browsing the Repository"s history.
  * See also `Commit.prototype.history()`
  *
  * @param {String|Oid} String sha or Oid
  * @param {Function} callback
  * @return {RevWalk}
  */
-Repo.prototype.createRevWalk = function() {
+Repository.prototype.createRevWalk = function() {
   var revWalk = Revwalk.createRevwalk(this);
   revWalk.repo = this;
   return revWalk;
@@ -180,7 +177,7 @@ Repo.prototype.createRevWalk = function() {
  * @param {Function} callback
  * @return {Branch}
  */
-Repo.prototype.getMaster = function(callback) {
+Repository.prototype.getMaster = function(callback) {
   this.getBranch("master", callback);
 };
 
@@ -196,7 +193,9 @@ Repo.prototype.getMaster = function(callback) {
  * @param {Function} callback
  * @return {Oid} The oid of the commit
  */
-Repo.prototype.createCommit = function(updateRef, author, committer, message, tree, parents, callback) {
+Repository.prototype.createCommit = function(
+  // FIXME
+  updateRef, author, committer, message, tree, parents, callback) {
   if (tree instanceof Tree) {
     Commit.createCommit.call(
       this,
@@ -211,7 +210,10 @@ Repo.prototype.createCommit = function(updateRef, author, committer, message, tr
   } else {
     var self = this;
     this.getTree(tree, function(error, tree) {
-      if (error) return callback(error);
+      if (error) {
+        return callback(error);
+      }
+
       Commit.createCommit.call(
         self,
         updateRef,
@@ -233,7 +235,7 @@ Repo.prototype.createCommit = function(updateRef, author, committer, message, tr
  * @param {Function} callback
  * @return {Blob}
  */
-Repo.prototype.createBlobFromBuffer = function(buffer, callback) {
+Repository.prototype.createBlobFromBuffer = function(buffer, callback) {
   Blob.createFrombuffer.call(this, buffer, buffer.length, callback);
 };
 
@@ -243,11 +245,11 @@ Repo.prototype.createBlobFromBuffer = function(buffer, callback) {
  * @param {Tree} tree
  * @param {Function} callback
  */
-Repo.prototype.treeBuilder = function(callback) {
+Repository.prototype.treeBuilder = function(callback) {
   var builder = TreeBuilder.create(null);
   builder.root = builder;
   builder.repo = this;
   return builder;
 };
 
-module.exports = Repo;
+module.exports = Repository;

lib/revwalk.js

@@ -28,8 +28,11 @@ Revwalk.Sort = {
  */
 Revwalk.prototype.sorting = function() {
   var sort = 0;
-  for (var i = 0; i < arguments.length; i++)
+
+  for (var i = 0; i < arguments.length; i++) {
     sort |= arguments[i];
+  }
+
   oldSorting.call(this, sort);
 };
 
@@ -48,11 +51,18 @@ Revwalk.prototype.walk = function(oid, callback) {
 
   function walk() {
     self.next(function revWalkNext(error, oid) {
-      if (error) return callback(error);
-      if (!oid) return callback();
+      if (error) {
+        return callback(error);
+      }
+
+      if (!oid) {
+        return callback();
+      }
 
       self.repo.getCommit(oid, function revWalkCommitLookup(error, commit) {
-        if (error) return callback(error);
+        if (error) {
+          return callback(error);
+        }
 
         callback(null, commit);
         walk();

lib/tree.js

@@ -2,10 +2,7 @@ var git = require("../");
 var Tree = git.Tree;
 var TreeBuilder = git.Treebuilder;
 var Diff = git.Diff;
-var DiffOptions = git.DiffOptions;
-var TreeEntry = require("./tree_entry");
 var events = require("events");
-var path = require("path");
 
 var oldBuilder = TreeBuilder.create;
 var oldEntryByIndex = Tree.prototype.entryByindex;
@@ -66,7 +63,9 @@ Tree.prototype.getEntry = function(path, callback) {
   // rely on oldGetEntry, in order to ensure that `parent` pointers are direct.
   var self = this;
   oldGetEntry.call(this, path, function(error, entry) {
-    if (error) return callback(error);
+    if (error) {
+      return callback(error);
+    }
 
     entry.parent = self;
     entry.path = function() { return path; };
@@ -88,22 +87,23 @@ Tree.prototype.entries = function() {
 };
 
 /**
- * Recursively walk the tree in breadth-first order. Fires an event for each entry.
+ * Recursively walk the tree in breadth-first order. Fires an event for each
+ * entry.
  *
  * @fires Tree#entry
  * @fires Tree#end
  *
- * @param {Boolean} [blobsOnly = true] True to emit only blob & blob executable entries.
+ * @param {Boolean} [blobsOnly = true] True to emit only blob & blob executable
+ * entries.
  *
  * @return {EventEmitter}
  */
 Tree.prototype.walk = function(blobsOnly) {
   blobsOnly = typeof blobsOnly === "boolean" ? blobsOnly : true;
 
-  var self = this,
-      event = new events.EventEmitter(),
-      entries = [],
-      errors = [];
+  var self = this;
+  var event = new events.EventEmitter();
+  var entries = [];
 
   var total = 1;
 

test/tests/blob.js

@@ -1,8 +1,6 @@
 var assert = require("assert");
 var path = require("path");
 
-var NodeGit = require("../../");
-
 describe("Blob", function() {
   var reposPath = path.resolve("test/repos/workdir/.git");
   var oid = "111dd657329797f6165f52f5085f61ac976dcf04";

test/tests/commit.js

@@ -8,8 +8,6 @@ describe("Commit", function() {
   var reposPath = path.resolve("test/repos/workdir/.git");
   var oid = "fce88902e66c72b5b93e75bdb5ae717038b221f6";
 
-  var Commit = require("../../lib/commit");
-
   beforeEach(function() {
     var test = this;