Gracefully shutdown

[ht-jo]

Hello.

I'm wondering of how to terminate a consumer gracefully, for instance, syncEvent is still running, but consumer.close() has called.

I couldn't find what waits for running tasks until finishing below code.

node-sinek/lib/librdkafka/NConsumer.js

Lines 962 to 981 in 462738c

	close(commit = false) {
	this.haltAnalytics();
	if (this.consumer) {
	this._inClosing = true;
	this._resume = false; //abort any running recursive consumption
	if(!commit){
	this.consumer.disconnect();
	//this.consumer = null;
	} else {
	this.consumer.commit();
	this.config.logger.info("Committing on close.");
	process.nextTick(() => {
	this.consumer.disconnect();
	//this.consumer = null;
	});
	}
	}
	}

Is there any code of termination gracefully in rdkafka or something else? Or does it just let them terminate without graceful termination? or would I implement code that clean the resources before shutdown for myself?

Thank you!

[Pruxis]

@krystianity is this something you want to support in the driver itself? As currently we are holding promises in memory and use consumer.pause() to stop listening to message to then await all ongoing promises before gracefully shutting down our process.

[krystianity]

Sorry for the late response.
I am not 100% certain, Blizzard/node-rdkafka#5 but it looks like node-rdkafka's dispatcher threads should take care of this automatically, as long as your application receives callbacks.

[krystianity]

Since sinek uses the HighLevelProducer you should only make sure that your produce acknowledgement settings allow for acks.