Reject obvious bad chart data

Dave Conway-Jones · Dave Conway-Jones · commit 55eff6ebe454 · 2022-09-09T10:44:18.000+01:00
to close #713
diff --git a/nodes/ui_chart.js b/nodes/ui_chart.js
@@ -72,6 +72,8 @@ module.exports = function(RED) {
                         return converted;
                     }
                     if (value[0].hasOwnProperty("series") && value[0].hasOwnProperty("data")) {
+                        if (!Array.isArray(value[0].series)) { node.error("series not array",msg); return; }
+                        if (!Array.isArray(value[0].data)) { node.error("Data not array",msg); return; }
                         var flag = true;
                         for (var dd = 0; dd < value[0].data.length; dd++ ) {
                             if (!isNaN(value[0].data[dd][0])) { flag = false; }

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,8 @@ module.exports = function(RED) {`
`72`	`72`	`return converted;`
`73`	`73`	`}`
`74`	`74`	`if (value[0].hasOwnProperty("series") && value[0].hasOwnProperty("data")) {`
	`75`	`+ if (!Array.isArray(value[0].series)) { node.error("series not array",msg); return; }`
	`76`	`+ if (!Array.isArray(value[0].data)) { node.error("Data not array",msg); return; }`
`75`	`77`	`var flag = true;`
`76`	`78`	`for (var dd = 0; dd < value[0].data.length; dd++ ) {`
`77`	`79`	`if (!isNaN(value[0].data[dd][0])) { flag = false; }`