feat: add assertion framework support to client authentication#336
Draft
dhensby wants to merge 4 commits intonode-oauth:masterfrom
Draft
feat: add assertion framework support to client authentication#336dhensby wants to merge 4 commits intonode-oauth:masterfrom
dhensby wants to merge 4 commits intonode-oauth:masterfrom
Conversation
5e54253 to
80571a7
Compare
80571a7 to
95cbfc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm looking to implement client assertion support. At the moment I'm leaning to keeping as much of this in
user-land code, but maybe we should have a way to register client authentication plugins (in a similar way that
we do with grant types). I think that might take quite a refactor (and breaking changes) to allow for that.
At the moment this is just a draft to check what the minimum interface is to get this working in user-land.
Some way to inject a body parser/interpreter is needed because the assertions contain most of the relevant request data that is typically just a property in the request body and most of the library makes an assumption that all the data is props in the body.
Linked issue(s)
N/A
Involved parts of the project
Client authentication
Added tests?
todo
OAuth2 standard
Example
This would be implemented something like this to support client assertions with JWT:
getting a token:
Implementing getClientFromAssertion: