Add commit message convention and coding rules #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankapunkt
reviewed
Oct 12, 2021
|
@HappyZombies @jwerre what do you think? Can you please take a look at it? It targets to be merged into #18 so we should first finish this one, before merging #18 |
jankapunkt
approved these changes
Oct 13, 2021
|
If nobody is against this I would merge :-) |
|
Looks good to me. And I am excited cuz I never used this git commit convention! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is necessary to use semantics in commit messages so that it is clear what meaning commit have in release process and affected release type (major/minor/patch). The semantics proposed in angular are very widely used - it is really convenient and understandable.
It is also necessary to mention the testing and documentation.