feat: implement trace option #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
附上 benchmark 开了 trace 居然还变快了 😔 |
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
+ Coverage 92.56% 92.61% +0.04%
==========================================
Files 6 6
Lines 686 704 +18
Branches 185 191 +6
==========================================
+ Hits 635 652 +17
- Misses 51 52 +1
Continue to review full report at Codecov.
|
|
cc: @popomore |
popomore
approved these changes
Aug 30, 2018
fengmk2
reviewed
Sep 26, 2018
| @@ -164,6 +164,7 @@ httpclient.request('http://nodejs.org', function (err, body) { | |||
| - ***proxy*** String | Object - proxy agent uri or options, default is `null`. | |||
| - ***lookup*** Function - Custom DNS lookup function, default is `dns.lookup`. Require node >= 4.0.0(for http protocol) and node >=8(for https protocol) | |||
| - ***checkAddress*** Function: optional, check request address to protect from SSRF and similar attacks. It receive tow arguments(`ip` and `family`) and should return true or false to identified the address is legal or not. It rely on `lookup` and have the same version requirement. | |||
| - ***trace*** Boolean - Enable capture stack include call site of library entrance, default is `false`. | |||
fengmk2
reviewed
Sep 26, 2018
lib/urllib.js
Outdated
| @@ -862,6 +865,8 @@ exports.requestWithCallback = function requestWithCallback(url, args, callback) | |||
| // request headers checker will throw error | |||
| try { | |||
| req = httplib.request(options, onResponse); | |||
| req._callSite = {}; | |||
| Error.captureStackTrace(req._callSite, requestWithCallback); | |||
warm up agent x 5,066 ops/sec ±6.64% (68 runs sampled)
request with no trace x 5,648 ops/sec ±1.25% (78 runs sampled)
request with trace x 4,518 ops/sec ±2.28% (74 runs sampled)
Fastest is request with no trace开了 trace 以后，性能还是有挺大影响的。大概在 20% 上下。 |
fengmk2
reviewed
Sep 26, 2018
package.json
Outdated
| @@ -57,6 +58,7 @@ | |||
| "intelli-espower-loader": "^1.0.1", | |||
| "istanbul": "*", | |||
| "jshint": "*", | |||
| "microtime": "^2.1.8", | |||
|
@killagu 请给出开启 trace 之后的具体效果示例是怎样的？ |
fengmk2
reviewed
Sep 26, 2018
| @@ -490,6 +492,7 @@ exports.requestWithCallback = function requestWithCallback(url, args, callback) | |||
| err.status = statusCode; | |||
| err.headers = headers; | |||
| err.res = response; | |||
| addLongStackTrace(err, req); | |||
There was a problem hiding this comment.
args.trace 没开启也不需要调用 addLongStackTrace
There was a problem hiding this comment.
addLongStackTrace 这个已经作出判断了。
|
@fengmk2 README 里面加上 trace 的效果了 |
fengmk2
reviewed
Sep 26, 2018
| Error: connect ECONNREFUSED 127.0.0.1:11 | ||
| at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1113:14) | ||
| -------------------- | ||
| at ~/workspace/urllib/lib/urllib.js:150:13 |
There was a problem hiding this comment.
推荐使用 projj https://npm.taobao.org/package/projj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.