Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: node-modules/urllib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.8.1
Choose a base ref
...
head repository: node-modules/urllib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.8.2
Choose a head ref
  • 5 commits
  • 10 files changed
  • 5 contributors

Commits on Aug 6, 2025

  1. Configuration menu
    Copy the full SHA
    54aa22a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2025

  1. chore: migrate from ESLint to oxlint with @eggjs/oxlint-config extens…

    …ion (#590)
    
    This PR migrates the linting setup from ESLint to oxlint, extending from
    the `@eggjs/oxlint-config` configuration package while maintaining
    backward compatibility.
    
    ## Changes Made
    
    - **Removed dependencies**: `eslint` and `eslint-config-egg`
    - **Added dependencies**: `oxlint` and `@eggjs/oxlint-config`
    - **Updated lint script**: Changed from `eslint src test --ext .ts
    --cache` to `oxlint src test`
    - **Extended configuration**: Added `.oxlintrc.json` that extends from
    `@eggjs/oxlint-config` with selective rule overrides to maintain
    compatibility
    - **Auto-fixed code**: Applied oxlint's auto-fixes for code style
    improvements
    
    ## Configuration Approach
    
    The new `.oxlintrc.json` extends from `@eggjs/oxlint-config` as the base
    configuration but selectively disables additional rules to preserve the
    original linting behavior. This approach:
    
    - Inherits the comprehensive EggJS oxlint configuration structure
    - Maintains the same 2 warnings as the original ESLint setup
    (`no-extend-native` rule)
    - Provides a foundation for future rule adoption when the codebase is
    ready
    
    ## Performance Benefits
    
    - **Significantly faster**: Linting now completes in ~21ms vs previous
    longer execution times
    - **Smaller dependency footprint**: Removed 140+ npm packages from the
    dependency tree
    - **Maintained compatibility**: Produces the same 2 warnings as the
    original ESLint setup
    
    ## Before vs After
    
    **Before (ESLint)**:
    ```bash
    ❯ eslint src test --ext .ts --cache
    /home/runner/work/urllib/urllib/src/utils.ts
      247:5  warning  String prototype is read only, properties should not be added  no-extend-native
      259:5  warning  String prototype is read only, properties should not be added  no-extend-native
    
    ✖ 2 problems (0 errors, 2 warnings)
    ```
    
    **After (oxlint with @eggjs/oxlint-config)**:
    ```bash
    ❯ oxlint src test
      ⚠ eslint(no-extend-native): String prototype is read-only, properties should not be added.
         ╭─[src/utils.ts:247:5]
    
      ⚠ eslint(no-extend-native): String prototype is read-only, properties should not be added.
         ╭─[src/utils.ts:259:5]
    
    Found 2 warnings and 0 errors.
    Finished in 21ms on 66 files using 4 threads.
    ```
    
    The migration successfully uses the official EggJS oxlint configuration
    while maintaining the same linting behavior for backward compatibility.
    
    <!-- START COPILOT CODING AGENT TIPS -->
    ---
    
    💡 You can make Copilot smarter by setting up custom instructions,
    customizing its development environment and configuring Model Context
    Protocol (MCP) servers. Learn more [Copilot coding agent
    tips](https://gh.io/copilot-coding-agent-tips) in the docs.
    
    ---------
    
    Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
    Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
    Copilot and fengmk2 authored Aug 9, 2025
    Configuration menu
    Copy the full SHA
    1ae3fd7 View commit details
    Browse the repository at this point in the history
  2. chore: ignore pnpm-lock.yaml

    fengmk2 committed Aug 9, 2025
    Configuration menu
    Copy the full SHA
    3cc8971 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2025

  1. Configuration menu
    Copy the full SHA
    0b1e89d View commit details
    Browse the repository at this point in the history
  2. Release 4.8.2

    [skip ci]
    
    ## <small>4.8.2 (2025-08-12)</small>
    
    * fix: enumerable WellFormed ([0b1e89d](0b1e89d))
    * chore: ignore pnpm-lock.yaml ([3cc8971](3cc8971))
    * chore: migrate from ESLint to oxlint with @eggjs/oxlint-config extension (#590) ([1ae3fd7](1ae3fd7)), closes [#590](#590)
    * chore: typo fix on release task name ([54aa22a](54aa22a))
    semantic-release-bot committed Aug 12, 2025
    Configuration menu
    Copy the full SHA
    00d2439 View commit details
    Browse the repository at this point in the history
Loading