Skip to content

0.14.7. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## O.14.7

Added an `index` argument to the `itemComponentFactory` callback in the `dynamicListComponent` function.

## O.14.6

Added comments to describe the `BranchedStepModelBuilder`, `SequentialStepModelBuilder` and `RootModelBuilder` classes.
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ Pro:

* [📖 Pro Editors](https://nocode-js.com/examples/sequential-workflow-editor-pro/webpack-pro-app/public/editors.html)
* [📫 Template System](https://nocode-js.com/examples/sequential-workflow-editor-pro/webpack-pro-app/public/template-system.html)
* [🎱 Dynamic Variables](https://nocode-js.com/examples/sequential-workflow-editor-pro/webpack-pro-app/public/dynamic-variables.html)

## 🚀 Installation

Expand Down
4 changes: 2 additions & 2 deletions demos/webpack-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"sequential-workflow-model": "^0.2.0",
"sequential-workflow-designer": "^0.21.2",
"sequential-workflow-machine": "^0.4.0",
"sequential-workflow-editor-model": "^0.14.6",
"sequential-workflow-editor": "^0.14.6"
"sequential-workflow-editor-model": "^0.14.7",
"sequential-workflow-editor": "^0.14.7"
},
"devDependencies": {
"ts-loader": "^9.4.2",
Expand Down
6 changes: 3 additions & 3 deletions editor/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sequential-workflow-editor",
"version": "0.14.6",
"version": "0.14.7",
"type": "module",
"main": "./lib/esm/index.js",
"types": "./lib/index.d.ts",
Expand Down Expand Up @@ -46,11 +46,11 @@
"prettier:fix": "prettier --write ./src ./css"
},
"dependencies": {
"sequential-workflow-editor-model": "^0.14.6",
"sequential-workflow-editor-model": "^0.14.7",
"sequential-workflow-model": "^0.2.0"
},
"peerDependencies": {
"sequential-workflow-editor-model": "^0.14.6",
"sequential-workflow-editor-model": "^0.14.7",
"sequential-workflow-model": "^0.2.0"
},
"devDependencies": {
Expand Down
17 changes: 12 additions & 5 deletions editor/src/components/dynamic-list-component.spec.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
import { SimpleEvent, ValueContext } from 'sequential-workflow-editor-model';
import { I18n, SimpleEvent, ValueContext } from 'sequential-workflow-editor-model';
import { Html } from '../core/html';
import { dynamicListComponent } from './dynamic-list-component';

interface TestItem {
id: number;
}

function testItemComponentFactory(item: TestItem) {
function testItemComponentFactory(item: TestItem, _: I18n, index: number) {
const view = Html.element('span', {
class: `test-item-${item.id}`
});
view.setAttribute('data-index', String(index));
return {
view: Html.element('span', {
class: `test-item-${item.id}`
}),
view,
onItemChanged: new SimpleEvent<TestItem>(),
onDeleteClicked: new SimpleEvent<void>(),
validate: () => {
Expand All @@ -32,7 +34,9 @@ describe('DynamicListComponent', () => {

expect(children.length).toBe(3);
expect(children[0].className).toBe('test-item-123');
expect(children[0].getAttribute('data-index')).toBe('0');
expect(children[1].className).toBe('test-item-456');
expect(children[1].getAttribute('data-index')).toBe('1');
expect(children[2].className).toBe('swe-validation-error');
});

Expand All @@ -47,13 +51,16 @@ describe('DynamicListComponent', () => {

expect(children.length).toBe(2);
expect(children[0].className).toBe('test-item-135');
expect(children[0].getAttribute('data-index')).toBe('0');
expect(children[1].className).toBe('swe-validation-error');

component.add({ id: 246 });

expect(children.length).toBe(3);
expect(children[0].className).toBe('test-item-135');
expect(children[0].getAttribute('data-index')).toBe('0');
expect(children[1].className).toBe('test-item-246');
expect(children[1].getAttribute('data-index')).toBe('1');
expect(children[2].className).toBe('swe-validation-error');
});

Expand Down
4 changes: 2 additions & 2 deletions editor/src/components/dynamic-list-component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export interface DynamicListItemComponent<TItem> extends Component {

export function dynamicListComponent<TItem, TItemComponent extends DynamicListItemComponent<TItem> = DynamicListItemComponent<TItem>>(
initialItems: TItem[],
itemComponentFactory: (item: TItem, i18n: I18n) => TItemComponent,
itemComponentFactory: (item: TItem, i18n: I18n, index: number) => TItemComponent,
context: ValueContext,
configuration?: DynamicListComponentConfiguration<TItem>
): DynamicListComponent<TItem, TItemComponent> {
Expand Down Expand Up @@ -74,7 +74,7 @@ export function dynamicListComponent<TItem, TItemComponent extends DynamicListIt

if (items.length > 0) {
items.forEach((item, index) => {
const component = itemComponentFactory(item, context.i18n);
const component = itemComponentFactory(item, context.i18n, index);
component.onItemChanged.subscribe(item => onItemChanged(item, index));
component.onDeleteClicked.subscribe(() => onItemDeleted(index));
view.insertBefore(component.view, validation.view);
Expand Down
2 changes: 1 addition & 1 deletion model/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sequential-workflow-editor-model",
"version": "0.14.6",
"version": "0.14.7",
"homepage": "https://nocode-js.com/",
"author": {
"name": "NoCode JS",
Expand Down