Fixes needed to get jazzy source build to work on nobleo-main #4
Conversation
mbharatheesha
changed the title
| find_package(pluginlib REQUIRED) | ||
| find_package(rviz_common REQUIRED) | ||
| find_package(rviz_default_plugins REQUIRED) | ||
| find_package(visualization_msgs REQUIRED) |
There was a problem hiding this comment.
Something seems off with the necessity of this change. When I compiled this yesterday from source when some of the deps (for ex: pluginlib, rviz_common, visualization_msgs) were not installed, compilation wouldn't succeed first time obviously because the deps weren't available. But the build would fail even after installing those packages.
Only after find_packageing them did the build succeed. Now, when I try building this package without any of these changes, compilation succeeds just fine!
There was a problem hiding this comment.
In principle, since autoware_perception_msgs, rviz_common and rviz_default_plugins are listed as <depend> in package.xml, they should be find_packaged?
| target_link_libraries(autoware_test_utils | ||
| yaml-cpp | ||
| ) | ||
|
|
There was a problem hiding this comment.
This change is definitely needed as the build of this package consistently fails with a linking error.
|
Thanks, please also open up an upstream PR. |
|
Done: autowarefoundation#9178 |
No description provided.