Skip to content

Commit 435dc83

Browse files
committed
tweak
1 parent 2c85ec9 commit 435dc83

File tree

4 files changed

+20
-16
lines changed

4 files changed

+20
-16
lines changed

jscomp/core/js_name_of_module_id.ml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
let (=) (x : int) (y:float) = assert false
2626
*)
2727

28-
let runtime_package_name = "bs-platform"
29-
3028
(* "xx/lib/ocaml/js.cmj"
3129
Enhancement: This can be delegated to build system
3230
*)
@@ -79,7 +77,8 @@ let string_of_module_id
7977
in
8078
begin match current_pkg_info with
8179
| Package_not_found -> assert false
82-
| Package_script -> runtime_package_name // dep_path // js_file
80+
| Package_script ->
81+
Js_packages_info.runtime_package_path module_system js_file
8382
| Package_found(cur_package_name, cur_path) ->
8483
if Js_packages_info.is_runtime_package cur_package_name then
8584
Ext_path.node_rebase_file
@@ -92,7 +91,7 @@ let string_of_module_id
9291
else
9392
match module_system with
9493
| NodeJS | Es6 ->
95-
runtime_package_name // dep_path // js_file
94+
Js_packages_info.runtime_package_path module_system js_file
9695
(** Note we did a post-processing when working on Windows *)
9796
| Es6_global
9897
->

jscomp/core/js_packages_info.ml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,16 @@ let is_runtime_package (x : string) =
5555
x = runtime_package_name
5656

5757
let (//) = Filename.concat
58-
let runtime_package_path (module_system : module_system) =
58+
let runtime_package_path
59+
(module_system : module_system)
60+
js_file =
5961
match module_system with
6062
| NodeJS ->
61-
runtime_package_name // "lib" // "js"
63+
runtime_package_name // "lib" // "js" // js_file
6264
| Es6
6365
| Es6_global ->
64-
runtime_package_name // "lib" // "es6"
65-
66+
runtime_package_name // "lib" // "es6" // js_file
67+
6668
type t =
6769
{
6870
name : package_name ;

jscomp/core/js_packages_info.mli

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ val same_package :
4242

4343
val runtime_package_path:
4444
module_system ->
45+
string ->
4546
string
4647

4748
type package_info

lib/whole_compiler.ml

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60399,6 +60399,7 @@ val same_package :
6039960399

6040060400
val runtime_package_path:
6040160401
module_system ->
60402+
string ->
6040260403
string
6040360404

6040460405
type package_info
@@ -60511,14 +60512,16 @@ let is_runtime_package (x : string) =
6051160512
x = runtime_package_name
6051260513

6051360514
let (//) = Filename.concat
60514-
let runtime_package_path (module_system : module_system) =
60515+
let runtime_package_path
60516+
(module_system : module_system)
60517+
js_file =
6051560518
match module_system with
6051660519
| NodeJS ->
60517-
runtime_package_name // "lib" // "js"
60520+
runtime_package_name // "lib" // "js" // js_file
6051860521
| Es6
6051960522
| Es6_global ->
60520-
runtime_package_name // "lib" // "es6"
60521-
60523+
runtime_package_name // "lib" // "es6" // js_file
60524+
6052260525
type t =
6052360526
{
6052460527
name : package_name ;
@@ -86203,8 +86206,6 @@ end = struct
8620386206
let (=) (x : int) (y:float) = assert false
8620486207
*)
8620586208

86206-
let runtime_package_name = "bs-platform"
86207-
8620886209
(* "xx/lib/ocaml/js.cmj"
8620986210
Enhancement: This can be delegated to build system
8621086211
*)
@@ -86257,7 +86258,8 @@ let string_of_module_id
8625786258
in
8625886259
begin match current_pkg_info with
8625986260
| Package_not_found -> assert false
86260-
| Package_script -> runtime_package_name // dep_path // js_file
86261+
| Package_script ->
86262+
Js_packages_info.runtime_package_path module_system js_file
8626186263
| Package_found(cur_package_name, cur_path) ->
8626286264
if Js_packages_info.is_runtime_package cur_package_name then
8626386265
Ext_path.node_rebase_file
@@ -86270,7 +86272,7 @@ let string_of_module_id
8627086272
else
8627186273
match module_system with
8627286274
| NodeJS | Es6 ->
86273-
runtime_package_name // dep_path // js_file
86275+
Js_packages_info.runtime_package_path module_system js_file
8627486276
(** Note we did a post-processing when working on Windows *)
8627586277
| Es6_global
8627686278
->

0 commit comments

Comments
 (0)