Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to semantic version #2

Open
noah978 opened this issue Jan 6, 2023 · 1 comment
Open

Swap to semantic version #2

noah978 opened this issue Jan 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@noah978
Copy link
Owner

noah978 commented Jan 6, 2023

Currently using packaging.version to compare versions found in AltSources and GitHub release tags. The AltSource API is designed to work explicitly with the semantic versioning protocol, so altparse should restrict valid versions to using that.

Here is the relevant PyPI and docs:

@noah978 noah978 added the enhancement New feature or request label Jan 6, 2023
@noah978
Copy link
Owner Author

noah978 commented Jan 6, 2023

There may be potential complications in this where users may have GitHub repos that don't follow semver, but the internal IPA being distributed does. However, it should be the responsibility of the IPA developer to appropriately distribute their app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant