Skip to content

Commit 53a8648

Browse files
committed
updated readme and fixed orderby in lessons
1 parent 2fb9aee commit 53a8648

File tree

3 files changed

+33
-13
lines changed

3 files changed

+33
-13
lines changed

.vscode/settings.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,6 @@
1111
"**/*.js.map": {
1212
"when": "$(basename)"
1313
}
14-
}
14+
},
15+
"prettier.tslintIntegration": true
1516
}

Readme.MD

Lines changed: 30 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,10 @@ If you found this project useful, then please consider giving it a ⭐️ on Git
1616

1717
1. You need to install PostgreSQL
1818

19-
- Install PostgreSQL for Windows and set following environment variable
20-
`C:\Program Files\PostgreSQL\10\bin`,
21-
`C:\Program Files\PostgreSQL\10\lib`
19+
- For Windows
20+
- Install PostgreSQL and set following environment variable
21+
`C:\Program Files\PostgreSQL\10\bin`,
22+
`C:\Program Files\PostgreSQL\10\lib`
2223
- For Ubuntu
2324

2425
- Installation
@@ -51,17 +52,19 @@ you can change port in `.env` file check `.env-sample`
5152
- CRUD operations for Lessons
5253
- REST API Request object validations - Basic
5354
- Error Logs
55+
- Setup docs
5456
- Seeder for DB
5557

5658
## Planned
5759

58-
- JWT login
59-
- Postman collections
60-
- Improve request Object Validations
61-
- Improve Error Messages for request failures
62-
- Project / DB Setup in Ubuntu - Docs
63-
- Security
64-
- Hosting
60+
- \[ ] JWT login
61+
- \[ ] Unit Testing
62+
- \[x] Postman collections
63+
- \[ ] Improve request Object Validations
64+
- \[ ] Improve Error Messages for request failures
65+
- \[x] Project / DB Setup in Ubuntu - Docs
66+
- \[ ] Security
67+
- \[ ] Hosting
6568

6669
## Contributing
6770

@@ -86,7 +89,23 @@ I welcome and encourage all pull requests. It usually will take me within 24-48
8689

8790
## Created & Maintained By
8891

89-
[@nmanikiran](https://github.com/nmanikiran) | [@curioustushar](https://github.com/curioustushar)
92+
<table>
93+
<tr>
94+
<td align="center"><a href="http://nmanikiran.com"><img src="https://avatars2.githubusercontent.com/u/3726349?s=460&v=4" width="100px;" alt="Mani Kiran"/><br /><sub><b>Mani Kiran N</b></sub></a><br />
95+
<a href="#" title="Code">💻 </a>
96+
<a href="#" title="Documentation">📖</a>
97+
<a href="#" title="Ideas">🤔</a>
98+
<a href="#" title="Reviewed Pull Requests">👀</a>
99+
<a href="#" title="Maintenance">🚧 </a>
100+
</td>
101+
<td align="center"><a href="https://curioustushar.github.io/"><img src="https://avatars3.githubusercontent.com/u/12570521?v=4" width="100px;" alt="Tushar Gupta"/><br /><sub><b>Tushar Gupta</b></sub></a><br />
102+
<a href="#" title="Code">💻 </a>
103+
<a href="#" title="Documentation">📖</a>
104+
<a href="#" title="Answering Questions">💬 </a>
105+
<a href="#" title="Maintenance">🚧 </a>
106+
</td>
107+
</tr>
108+
</table>
90109

91110
Feel free to reach out to me through @nmanikiran if you have any questions or feedback!
92111

src/controllers/LessonsCtrl.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export default class LessonRoutes {
66
constructor() {}
77

88
getAllLessons(req: Request, res: Response, next: NextFunction) {
9-
LessonRepo.getAllLessons({ order: ['seqNo'] })
9+
LessonRepo.getAllLessons({ order: ['id'] })
1010
.then(result => res.json(result))
1111
.catch(err => {
1212
apiErrorHandler(err, req, res, 'Fetch All Lessons failed.');

0 commit comments

Comments
 (0)