Visualiser crashes on double spaces

[amadanmath]

XML conflates spaces; which leads to a DOM exception when I'm trying to read the position of the last character (since apparently one of the spaces isn't counted as a character).

If I try to replace spaces with nbsp's, I get literal   on screen. I tried to do a mockup to ask on Stack Overflow, but I couldn't reproduce it in the mockup.

I already spent over two or three hours with this - I give up, since there's too many other things I have to do.

[spyysalo]

Could we do a serverside workaround (hopefully temporary...) that replaces
some (every second?) of each set of consecutive spaces with   before
sending the text to the client? This would allow us to keep the character
offsets and not to mess with the input data on the server, and presumably a
non-breaking space received input would be honored in rendering..?

In any case, this is likely to be a very rare issue, and we don't need to
have a terribly nice solution, just avoid crashing.

On Tue, Jun 14, 2011 at 2:29 AM, amadanmath <
reply@reply.github.com>wrote:

XML conflates spaces; which leads to a DOM exception when I'm trying to
read the position of the last character (since apparently one of the spaces
isn't counted as a character).

If I try to replace spaces with nbsp's, I get literal   on screen. I
tried to do a mockup to ask on Stack Overflow, but I couldn't reproduce it
in the mockup.

I already spent over two or three hours with this - I give up, since
there's too many other things I have to do.

Reply to this email directly or view it on GitHub:
https://github.com/TsujiiLaboratory/brat/issues/262

[amadanmath]

In my initial post:

If I try to replace spaces with nbsp's, I get literal   on screen.

[spyysalo]

OK, I took that to mean something that happens if you try to make the change
dynamically in JS (somehow); I didn't realize it's actually impossible to
get a non-breaking space in the SVG text.

On Tue, Jun 14, 2011 at 2:45 AM, amadanmath <
reply@reply.github.com>wrote:

In my initial post:

If I try to replace spaces with nbsp's, I get literal   on screen.

Reply to this email directly or view it on GitHub:
https://github.com/TsujiiLaboratory/brat/issues/262#issuecomment-1360557

[amadanmath]

Apparently, you can. Just not while I'm watching >.<

I so hate elusive bugs I can't trace...

[spyysalo]

The "fix" is quite an ugly hack (and marked so in the code), but this does at least do away with the edge-case crash for me, so closed for now.

[spyysalo]

Reopening for a suggestion: wouldn't xml:space="preserve" do the trick without the ugly hack? (if not, just comment and close again)

[amadanmath]

It just might, we'd need to try. I've never heard of it before, but sounds just like what the doctor ordered. We also have to see about how well browsers comply, I found this (admittedly, apparently resolved as of 2008): https://bugzilla.mozilla.org/show_bug.cgi?id=319786

[spyysalo]

Postponing to summer stabilization as the current hack resolves the main issue, i.e. the crash.

@spyysalo and @amadanmath: Um, why the heck is this one still open? Is this still an issue?

[spyysalo]

Pretty sure the idea was that we might get it resolved more cleanly. Have a
look at 75fa75f, it's terrible. If you
prefer, go ahead and close and open a new, more specific issue for what
remains of this.

@spyysalo: It was mostly the fact that it was marked for a nine month old milestone. Issuing a new one and putting it on the appropriate milestone.