Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note on derived return type for value function #4628

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Add note on derived return type for value function #4628

merged 2 commits into from
Jan 26, 2025

Conversation

nlohmann
Copy link
Owner

This PR adds a note and an example to the documentation of the value function that addresses issue #4626.

@nlohmann
📝 add note on derived return type
3f9d9c7 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 25, 2025
@nlohmann nlohmann linked an issue Jan 25, 2025 that may be closed by this pull request
basic_json::operator[key] and basic_json::value(key) return different values #4626
Closed
2 tasks
@nlohmann nlohmann mentioned this pull request Jan 25, 2025
Closed
2 tasks
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Jan 25, 2025
@coveralls
Copy link

coveralls commented Jan 25, 2025 •
edited
Loading

Coverage Status

coverage: 99.186%. remained the same
when pulling c40676e on value_documentation
into d0789e3 on develop.

@nlohmann
📝 add note on derived return type
c40676e 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann merged commit e90c860 into develop Jan 26, 2025
131 checks passed
@nlohmann nlohmann deleted the value_documentation branch January 26, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr approved these changes

Assignees
No one assigned
Labels
documentation M review needed It would be great if someone could review the proposed changes.
Projects
None yet
Milestone
Release 3.11.4
Development

Successfully merging this pull request may close these issues.

basic_json::operator[key] and basic_json::value(key) return different values
3 participants
@nlohmann @coveralls @gregmarr