-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set parent pointers for values inserted via update() (fixes #3007). #3008
Conversation
Ah, my new test won't compile/work unless Edit: Never mind, figured it out. Also moved my test to the proper location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks a lot! I will merge this once AppVeyor completes. |
Great! Thanks for the quick merge! |
Fixes parent pointers not being set when using
update()
(#3007).I've added a test which successfully failed before my changes and passed afterwards.
Pull request checklist
include/nlohmann
directory, runmake amalgamate
to create the single-header filesingle_include/nlohmann/json.hpp
. The whole process is described here.