Logger overloads generated by T4 #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync back
No PERL script anymore
Moved 6 loglevel overloads to T4 template. T4 is default included in VS2012+
|
Note: did this change to easily implement #431 in the near future. |
|
Probably the T4 is too fancy to handle. Issue 1 (issue #604)The "sync projects" corrupts the before <Compile Include="Logger1.cs">
<AutoGen>True</AutoGen>
<DesignTime>True</DesignTime>
<DependentUpon>Logger.tt</DependentUpon>
</Compile>after <Compile Include="Logger1.cs" />Issue 2 (issue #605)The unit test Those 2 issues has to be solved. |
This was referenced Feb 21, 2015
``` <Customize FileSet="logger.tt" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> <AutoGen>True</AutoGen> <DesignTime>True</DesignTime> <DependentUpon>Logger.tt</DependentUpon> </Customize> ``` for Logger1.cs
|
PR is ready for merge |
304NotModified
added a commit
that referenced
this pull request
Feb 28, 2015
Logger overloads generated by T4
ghost
mentioned this pull request
|
When can we expect a new release with the exception logging fix? |
|
2 June |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great improvement in code quality, the logger methods for the six levels (Trace, Debug, Info etc) are now generated with a T4 template. (
.ttfile)This will reduce the lines of code that should be maintained and guarantees the consistency between the overloads. The lines of code in the
Loggerclass reduced from ~2000 to ~500 + ~300 (T4 template)T4 templates are run at build time and the T4 generator is built in VIsual Studio 2012+
The output is compared with a text diff and nothing has changed in the signature of the methods (= the same methods, the same parameter names, the same attributes). So nothing functional has changed!
PS: there was only 1 change, beside some spaces, the code of
Error<TArgument>was inconsistent. This is now fixed. (see screenshot, left=old, right=new)