Throw exception if unknown auth method is used.

stloyd · stloyd · commit a886a1bf59ae · 2012-12-27T11:17:21.000+01:00
Removed ambiguous phpdocs from tests.
diff --git a/lib/Github/HttpClient/Listener/AuthListener.php b/lib/Github/HttpClient/Listener/AuthListener.php
@@ -90,6 +90,9 @@ public function preSend(RequestInterface $request)
 
                 $request->fromUrl(new Url($url));
                 break;
+
+            default:
+                throw new InvalidArgumentException(sprintf('Unknown method called "%s".', $this->method));
         }
     }
 
diff --git a/test/Github/Tests/Api/AbstractApiTest.php b/test/Github/Tests/Api/AbstractApiTest.php
@@ -4,11 +4,6 @@
 
 use Github\Api\AbstractApi;
 
-/**
- * AbstractApi test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class AbstractApiTest extends \PHPUnit_Framework_TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/CurrentUser/DeployKeysTest.php b/test/Github/Tests/Api/CurrentUser/DeployKeysTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * CurrentUser deploy keys api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class DeployKeysTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/CurrentUser/EmailsTest.php b/test/Github/Tests/Api/CurrentUser/EmailsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * CurrentUser emails api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class EmailsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/CurrentUser/FollowersTest.php b/test/Github/Tests/Api/CurrentUser/FollowersTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * CurrentUser followers api test case
- *
- * @author Joseph Bielawski <stloyd@gmail.com>
- */
 class FollowersTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/CurrentUser/WatchersTest.php b/test/Github/Tests/Api/CurrentUser/WatchersTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * CurrentUser watchers api test case
- *
- * @author Joseph Bielawski <stloyd@gmail.com>
- */
 class WatchersTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/CurrentUserTest.php b/test/Github/Tests/Api/CurrentUserTest.php
@@ -2,11 +2,6 @@
 
 namespace Github\Tests\Api;
 
-/**
- * CurrentUser api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class CurrentUserTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/GistsTest.php b/test/Github/Tests/Api/GistsTest.php
@@ -2,11 +2,6 @@
 
 namespace Github\Tests\Api;
 
-/**
- * Gist api test case 
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class GistsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/GitData/BlobsTest.php b/test/Github/Tests/Api/GitData/BlobsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * GitData blobs api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class BlobsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/GitData/CommitsTest.php b/test/Github/Tests/Api/GitData/CommitsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * GitData commits api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class CommitsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/GitData/ReferencesTest.php b/test/Github/Tests/Api/GitData/ReferencesTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * GitData references api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class ReferencesTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/GitData/TagsTest.php b/test/Github/Tests/Api/GitData/TagsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * GitData tags api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class TagsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/GitData/TreesTest.php b/test/Github/Tests/Api/GitData/TreesTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * GitData trees api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class TreesTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/GitDataTest.php b/test/Github/Tests/Api/GitDataTest.php
@@ -2,11 +2,6 @@
 
 namespace Github\Tests\Api;
 
-/**
- * GitData api test case 
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class GitDataTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Issue/CommentsTest.php b/test/Github/Tests/Api/Issue/CommentsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Issue comments api test case 
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class CommentsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Issue/EventsTest.php b/test/Github/Tests/Api/Issue/EventsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Issue events api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class EventsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Issue/LabelsTest.php b/test/Github/Tests/Api/Issue/LabelsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Issue labels api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class LabelsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Issue/MilestonesTest.php b/test/Github/Tests/Api/Issue/MilestonesTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Issue milestones api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class MilestonesTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/IssueTest.php b/test/Github/Tests/Api/IssueTest.php
@@ -2,11 +2,6 @@
 
 namespace Github\Tests\Api;
 
-/**
- * Issue api test case 
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class IssueTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/MarkdownTest.php b/test/Github/Tests/Api/MarkdownTest.php
@@ -2,11 +2,6 @@
 
 namespace Github\Tests\Api;
 
-/**
- * Markdown api test case 
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class MarkdownTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Organization/MembersTest.php b/test/Github/Tests/Api/Organization/MembersTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Organization members api test case 
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class MembersTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Organization/TeamsTest.php b/test/Github/Tests/Api/Organization/TeamsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Organization teams api test case 
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class TeamsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/OrganizationTest.php b/test/Github/Tests/Api/OrganizationTest.php
@@ -2,11 +2,6 @@
 
 namespace Github\Tests\Api;
 
-/**
- * Organization api test case 
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class OrganizationTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/PullRequestTest.php b/test/Github/Tests/Api/PullRequestTest.php
@@ -2,11 +2,6 @@
 
 namespace Github\Tests\Api;
 
-/**
- * PR api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class PullRequestTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/RepoTest.php b/test/Github/Tests/Api/RepoTest.php
@@ -2,11 +2,6 @@
 
 namespace Github\Tests\Api;
 
-/**
- * Repository api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class RepoTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Repository/CollaboratorsTest.php b/test/Github/Tests/Api/Repository/CollaboratorsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Repository collaborators api test case 
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class CollaboratorsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Repository/CommentsTest.php b/test/Github/Tests/Api/Repository/CommentsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Repository comments api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class CommentsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Repository/CommitsTest.php b/test/Github/Tests/Api/Repository/CommitsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Repository commits api test case 
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class CommitsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Repository/ContentsTest.php b/test/Github/Tests/Api/Repository/ContentsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Repository contents api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class ContentsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Repository/DeployKeysTest.php b/test/Github/Tests/Api/Repository/DeployKeysTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Repository keys api test case 
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class DeployKeysTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Repository/DownloadsTest.php b/test/Github/Tests/Api/Repository/DownloadsTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Repository downloads api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class DownloadsTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Repository/ForksTest.php b/test/Github/Tests/Api/Repository/ForksTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Repository forks api test case
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class ForksTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Repository/HooksTest.php b/test/Github/Tests/Api/Repository/HooksTest.php
@@ -4,11 +4,6 @@
 
 use Github\Tests\Api\TestCase;
 
-/**
- * Repository hooks api test case 
- *
- * @author Leszek Prabucki <leszek.prabucki@gmail.com>
- */
 class HooksTest extends TestCase
 {
     /**
diff --git a/test/Github/Tests/Api/Repository/LabelsTest.php b/test/Github/Tests/Api/Repository/LabelsTest.php
diff --git a/test/Github/Tests/Api/UserTest.php b/test/Github/Tests/Api/UserTest.php
diff --git a/test/Github/Tests/ClientTest.php b/test/Github/Tests/ClientTest.php
diff --git a/test/Github/Tests/HttpClient/HttpClientTest.php b/test/Github/Tests/HttpClient/HttpClientTest.php
diff --git a/test/Github/Tests/HttpClient/Listener/AuthListenerTest.php b/test/Github/Tests/HttpClient/Listener/AuthListenerTest.php
diff --git a/test/Github/Tests/HttpClient/Listener/ErrorListenerTest.php b/test/Github/Tests/HttpClient/Listener/ErrorListenerTest.php
diff --git a/test/Github/Tests/Mock/TestHttpClient.php b/test/Github/Tests/Mock/TestHttpClient.php

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,9 @@ public function preSend(RequestInterface $request)`
`90`	`90`
`91`	`91`	`$request->fromUrl(new Url($url));`
`92`	`92`	`break;`
	`93`	`+`
	`94`	`+ default:`
	`95`	`+ throw new InvalidArgumentException(sprintf('Unknown method called "%s".', $this->method));`
`93`	`96`	`}`
`94`	`97`	`}`
`95`	`98`