IngresDBI Trac ticket #502 select on LONG NVARCHAR (aka NCLOB) return empty strings

LONG NVARCHAR length indicator orInd was not being set
resulting in empty strings being returned. Noticed same
inconsistency with other LONG types (LONG BYTE and LONG VARCHAR),
lack of correct orInd was not returning incorrect results for
these types but is inconsistent hence the change.

Whilst delving into this code added needed debug statement so
that unsupported types are seen in trace logs.


git-svn-id: http://code.ingres.com/ingres/drivers/python/main@2286 45b5d43f-8932-4c86-835a-3654e5842839

Author: clach04

dbi/iidbicurs.c

@@ -152,6 +152,13 @@
 **      Crash was caused by access to uninitialized pointer.
 **      Bindparam code for NULL/None removed, now uses generic bind code
 **      as used for strings and decimal.
+**  24-Nov-2009 (clach04)
+**      Trac ticket 502 empty string returned for LONG NVARCHAR/NCLOB columns
+**      LONG NVARCHAR length indicator orInd was not being set
+**      resulting in empty strings being returned. Noticed same
+**      issue with other LONG types (LONG BYTE and LONG VARCHAR),
+**      lack of correct orInd was not an issue for these types
+**      but is inconsistent hence the change.
 **/
 
 /* 
@@ -662,7 +669,7 @@ dbi_cursorFetchone( IIDBI_STMT *pstmt )
     RETCODE rc, return_code;
     HSTMT hstmt = pstmt->hdr.handle;
     int i, nType;
-    SQLINTEGER orind;
+    SQLINTEGER orind=0;
 #define SEGMENT_SIZE 1000000
     char *segment = NULL;
     int count;
@@ -699,6 +706,7 @@ dbi_cursorFetchone( IIDBI_STMT *pstmt )
                 pstmt->descriptor[i]->data = NULL;
                 pstmt->descriptor[i]->isNull = 0;
                 pstmt->descriptor[i]->precision = 0;
+                pstmt->descriptor[i]->orInd = 0;
                 if (pstmt->outputColumnIndex && (i+1) == 
                     pstmt->outputColumnIndex)
                     segment_size = pstmt->outputSegmentSize;
@@ -757,6 +765,7 @@ dbi_cursorFetchone( IIDBI_STMT *pstmt )
                     {
                         pstmt->descriptor[i]->data = segment;
                         pstmt->descriptor[i]->precision = count;
+                        pstmt->descriptor[i]->orInd = count;
                     }
                 }
                 if (!SQL_SUCCEEDED(rc))
@@ -779,6 +788,7 @@ dbi_cursorFetchone( IIDBI_STMT *pstmt )
                 pstmt->descriptor[i]->data = NULL;
                 pstmt->descriptor[i]->isNull = 0;
                 pstmt->descriptor[i]->precision = 0;
+                pstmt->descriptor[i]->orInd = 0;
                 if (pstmt->outputColumnIndex && (i+1) == 
                     pstmt->outputColumnIndex)
                     segment_size = pstmt->outputSegmentSize;
@@ -806,6 +816,7 @@ dbi_cursorFetchone( IIDBI_STMT *pstmt )
                 {
                     pstmt->descriptor[i]->data = segment;
                     pstmt->descriptor[i]->precision = orind;
+                    pstmt->descriptor[i]->orInd = orind;
                 }
                 else
                 {
@@ -841,6 +852,7 @@ dbi_cursorFetchone( IIDBI_STMT *pstmt )
                     {
                         pstmt->descriptor[i]->data = segment;
                         pstmt->descriptor[i]->precision = count;
+                        pstmt->descriptor[i]->orInd = count;
                     }
                 }
                 if (!SQL_SUCCEEDED(rc))
@@ -862,6 +874,7 @@ dbi_cursorFetchone( IIDBI_STMT *pstmt )
                 pstmt->descriptor[i]->data = NULL;
                 pstmt->descriptor[i]->isNull = 0;
                 pstmt->descriptor[i]->precision = 0;
+                pstmt->descriptor[i]->orInd = 0;
                 if (pstmt->outputColumnIndex && (i+1) == 
                     pstmt->outputColumnIndex)
                     segment_size = pstmt->outputSegmentSize;
@@ -920,6 +933,7 @@ dbi_cursorFetchone( IIDBI_STMT *pstmt )
                     {
                         pstmt->descriptor[i]->data = segment;
                         pstmt->descriptor[i]->precision = count;
+                        pstmt->descriptor[i]->orInd = count;
                     }
                 }
                 if (!SQL_SUCCEEDED(rc))

dbi/ingresdbi.c

@@ -255,6 +255,8 @@
 **      calls to (for instance) fetch on a closed session will be using
 **      invalid pointers as the driver is responsible for free'ing each
 **      connection/cursror resource. Other Windows ODBC drivers also crash.
+**  24-Nov-2009 (clach04)
+**      Added debug trace for unknown types on select/fetch.
 **/
 
 static PyObject *IIDBI_Warning;
@@ -4517,6 +4519,7 @@ static PyObject *IIDBI_cursorFetch(IIDBI_CURSOR *self)
                     break;
 
             default:
+                DBPRINTF(DBI_TRC_STAT)("IIDBI_cursorFetch defaulting col %d type descriptor[i]->type %d\n", i, descriptor[i]->type);
                 PyTuple_SetItem(row, i, 
                     PyString_FromStringAndSize(descriptor[i]->data,
                                                 (Py_ssize_t) descriptor[i]->orInd)