Remove return value from pause#829
Remove return value from pause#829Thomasdezeeuw wants to merge 1 commit intonix-rust:masterfrom Thomasdezeeuw:pause
pause#829Conversation
Closes issue #827.
|
I'll redo this as #828, since it might create another conflict when adding to the changelog. |
| // Safe: The child only calls `pause` and/or `_exit`, which are async-signal-safe. | ||
| match fork().expect("Error: Fork Failed") { | ||
| Child => pause().unwrap_or_else(|_| unsafe { _exit(123) }), | ||
| Child => pause(), |
There was a problem hiding this comment.
I believe that you have to call _exit() instead of letting the thread naturally exit because of how Rust's standard cleanup isn't signal safe or something. @asomers Can you verify this?
There was a problem hiding this comment.
Yep. The standard cleanup may try to access shared resources that were exclusively held by other threads at the time that fork happened. But those other threads don't exist in the child, so your thread will never get the resources, and deadlock will result. That's why we call _exit in child threads.
There was a problem hiding this comment.
Maybe I'm misunderstanding something but, isn't unwrap_or_else only called if pause fails and returns an error. Since that can't happend anymore _exit can never be called, and would have never be called even without the change.
There was a problem hiding this comment.
I've fixed this in #836, for some reason this pull request is now "from unknown repository". I don't know how to fix that, so instead I created an new pr.
3 participants
Closes issue #827.