Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests should protect concurrent access to signal handlers #579

Merged
merged 1 commit into from
Apr 16, 2017
Merged

tests should protect concurrent access to signal handlers #579

merged 1 commit into from
Apr 16, 2017

Conversation

asomers
Copy link
Member

@asomers asomers commented Apr 15, 2017

Adds a mutex to protect access to SIGUSR2 signal handlers by the AIO
tests.

Fixes #578

@asomers asomers mentioned this pull request Apr 15, 2017
Merged
@Susurrus Susurrus changed the base branch from master to new-ci/master April 15, 2017 19:07
@Susurrus
Copy link
Contributor

@homu retry

@Susurrus
Copy link
Contributor

@asomers I switched the PR branch to new-ci/master, as the MIPS tests don't work on master right now. Can you re-push your commits to re-run Travis?

@asomers
Copy link
Member Author

asomers commented Apr 15, 2017

@Susurrus why don't we just wait until after you've merged new-ci/master? Then I'll rebase. I don't want to hold up that work.

@Susurrus
Copy link
Contributor

@asomers Sure.

@Susurrus Susurrus changed the base branch from new-ci/master to master April 15, 2017 21:14
@Susurrus
Copy link
Contributor

@asomers Can you rebase this (#536 just landed)?

@asomers
tests should protect concurrent access to signal handlers
46ed256 
Adds a mutex to protect access to SIGUSR2 signal handlers by the AIO
tests.

Fixes nix-rust#578
@asomers
Copy link
Member Author

asomers commented Apr 15, 2017

Well, it didn't fix the mips errors, but I still think that this is the right thing to do. Does anybody object to adding the dependency on lazy_static ?

@posborne
Copy link
Member

Does anybody object to adding the dependency on lazy_static?

Nope, that should be fine. Doesn't really drag in anything too much extra.

@asomers
Copy link
Member Author

asomers commented Apr 16, 2017

bors r+

bors bot added a commit that referenced this pull request Apr 16, 2017
@bors
Merge #579
8c47de4 
579: tests should protect concurrent access to signal handlers r=asomers
Adds a mutex to protect access to SIGUSR2 signal handlers by the AIO
tests.

Fixes #578
@bors
Copy link
Contributor

bors bot commented Apr 16, 2017

Build succeeded

@bors bors bot merged commit 46ed256 into nix-rust:master Apr 16, 2017
@asomers asomers mentioned this pull request Apr 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asomers @Susurrus @posborne