Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netlink protocol values to socket consts #426

Closed
wants to merge 1 commit into from

Conversation

mrjana
Copy link

@mrjana mrjana commented Sep 10, 2016

Signed-off-by: Jana Radhakrishnan mrjana@gmail.com

Signed-off-by: Jana Radhakrishnan <mrjana@gmail.com>
@mrjana mrjana changed the title Add netlink protocol values to socker consts Add netlink protocol values to socket consts Sep 10, 2016
Copy link
Contributor

@fiveop fiveop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our goal is to have constant definitions in rust-lang/libc use them in nix. The reason is that libc has code that tests whether the values are correct and to avoid code duplication between the two projects. (See CONVENTIONS.md).

Since libc also links against linux/netlink.h you should be able to add these constants in libc. Once in there, you can adapt this PR to reference the libc constants.

Thank you.

@mrjana
Copy link
Author

mrjana commented Sep 15, 2016

@fiveop Thanks for the pointer. Will fix it in rust-lang/libc.

@fiveop
Copy link
Contributor

fiveop commented Oct 3, 2016

@mrjana, are you planning on adapting this PR, now that rust-lang/libc#400 has been merged?

@mrjana
Copy link
Author

mrjana commented Oct 3, 2016

@fiveop Yes, will do so this week.

@posborne
Copy link
Member

@mrjana Any progress on this one?

@Susurrus
Copy link
Contributor

@mrjana Are you still interested in getting this merged?

@mrjana
Copy link
Author

mrjana commented Jun 20, 2017

@Susurrus Oh shoot! Thanks for the ping. Forgotten about it as I got busy with work. Will get it in soon.

@Susurrus
Copy link
Contributor

These constants are already defined in libc and #647 is going to do away with the consts module completely, so this change is no longer necessary. I'm going to close this.

@Susurrus Susurrus closed this Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants