Fix Solaris CI after solaris-vm was updated to CBE release 11.4.81 #2643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
reviewed
Jun 16, 2025
| @@ -396,7 +396,7 @@ jobs: | |||
| uname -a | |||
| run: | | |||
| export PATH=$HOME/.rust_solaris/bin:$PATH | |||
| cargo build --target x86_64-pc-solaris --all-targets --all-features && sudo cargo test | |||
| cargo build --target x86_64-pc-solaris --all-targets --all-features && sudo env PATH=$PATH cargo test | |||
There was a problem hiding this comment.
This looks like exactly what sudo --preserve-env=PATH is for. Does solaris's sudo have that option?
There was a problem hiding this comment.
This looks like exactly what
sudo --preserve-env=PATHis for. Does solaris's sudo have that option?
It does. But I think it needs to be enabled somewhere in configuration. Which doesn't seem to be the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned in #2642
New Solaris CBE release 11.4.81 comes with updated version of
sudo.