MacOS socket audit token #2529
Merged
MacOS socket audit token #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the LOCAL_PEERTOKEN it adds may be guaranteed to be available. Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
…d of 0 Should be more readable. Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
audit_token_t is taken from endpoint-sec-sys. Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
PaulDance
force-pushed
the
macos-socket-token
branch
from
b1e47c0
to
c5d6f2b
Compare
SteveLauC
approved these changes
Oct 30, 2024
|
Hey, thanks for the super quick reply!
Yes, I double-checked and they actually do run! I initially pushed just to see the result of the CI run before launching my whole macOS machinery (I don't work from one) and fixing any upcoming issue, but when I saw that every test job was green on the first attempt, I was immediately doubtful and when searching with my browser's search, I couldn't find the test name in the logs, but that was just due to GitHub's auto load and unload of logs, so the integrated search is really the source of truth here 😅 Anyway, if everything is good for you, then it is for me too! |
|
Super cool, thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This adds a new API for
getsockoptaroundlibc::LOCAL_PEERTOKENfollowing rust-lang/libc#3929. The return type definition is the low-levelaudit_token_tas defined inosfmk/mach/message.hand taken fromendpoint-sec-sys. A small test was added for it.Checklist:
CONTRIBUTING.md