sockopt add OpenBSD's SO_RTABLE to set the route table. #2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Aug 6, 2023
| /// Get/set a filter on this socket before accepting connections similarly | ||
| /// to Linux's TCP_DEFER_ACCEPT but after the listen's call. | ||
| AcceptFilter, | ||
| Both, |
There was a problem hiding this comment.
This is set-only, at least on FreeBSD.
There was a problem hiding this comment.
No, looking at the kernel code I see that you're right. I was just confused by the wording in the man page.
Also SO_ACCEPTFILTER for FreeBSD/NetBSD.
asomers
approved these changes
Aug 6, 2023
| /// Get/set a filter on this socket before accepting connections similarly | ||
| /// to Linux's TCP_DEFER_ACCEPT but after the listen's call. | ||
| AcceptFilter, | ||
| Both, |
There was a problem hiding this comment.
No, looking at the kernel code I see that you're right. I was just confused by the wording in the man page.
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also SO_ACCEPTFILTER for FreeBSD/NetBSD.