Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sched_yield. #1050

Merged
merged 1 commit into from
May 18, 2019
Merged

Implement sched_yield. #1050

merged 1 commit into from
May 18, 2019

Conversation

sunfishcode
Copy link
Contributor

This adds the sched_yield function, which is part of POSIX:

http://pubs.opengroup.org/onlinepubs/9699919799/functions/sched_yield.html

and widely implemented on Unix-family platforms.

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc comments please?

@sunfishcode
Copy link
Contributor Author

Doc comments added!

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc comment should contain a link to the man page. The link you used in the commit message will do nicely. We probably don't need a test for this function just because there's nothing for a test to observe.

@sunfishcode
Copy link
Contributor Author

Link added to the doc comment :-).

@asomers
Copy link
Member

asomers commented May 17, 2019

Sorry I didn't notice this for a few days. Please squash and then I'll merge it.

@sunfishcode
Copy link
Contributor Author

Ok, it's squashed. The CI is failing, though it appears unrelated to the PR here.

@asomers
Copy link
Member

asomers commented May 17, 2019

The breakage was caused by rust-lang/libc@24f8972 . I'll fix it.

@asomers
Copy link
Member

asomers commented May 17, 2019

Try rebasing now.

This adds the `sched_yield` function, which is part of POSIX:

http://pubs.opengroup.org/onlinepubs/9699919799/functions/sched_yield.html

and widely implemented on Unix-family platforms.
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request May 18, 2019
1050: Implement `sched_yield`. r=asomers a=sunfishcode

This adds the `sched_yield` function, which is part of POSIX:

http://pubs.opengroup.org/onlinepubs/9699919799/functions/sched_yield.html

and widely implemented on Unix-family platforms.

Co-authored-by: Dan Gohman <sunfish@mozilla.com>
@bors
Copy link
Contributor

bors bot commented May 18, 2019

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants