-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TPROXY-related Linux things #1025
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github understands "Fixes" in commit messages, but I don't think it understands "Should close". You should change your commit message. And you'll need to rebase after PR #1020. Don't forget a CHANGELOG message.
It underlines the word "close" with a tooltip "This pull request closes issue #1023". |
Is this feature needed in Nix? Shall I try to make it mergeable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a worthwhile addition. Could you please enable it for FreeBSD too? It's been available since 12.0.
Is libc interface for FreeBSD for this feature exactly the same as in Linux? |
I think so. Read the details here: https://www.freebsd.org/cgi/man.cgi?query=ip&apropos=0&sektion=4&manpath=FreeBSD+12.1-RELEASE+and+Ports&arch=default&format=html |
This beings `OrigDstAddrV4` and `OrigDstAddrV6` `recvmsg` messages and associated socket options `RecvOrigDstAddrV4` and `RecvOrigDstAddrV6`. Should close nix-rust#1023.
@asomers, What to use instead of Or is trying to enable support of this on FreeBSD without actually testing it on a real FreeBSD is counterproductive? |
For the level use |
Should close #1023.
Depends on rust-lang/libc#1252
Example code: