Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests should protect concurrent access to signal handlers #578

Closed
asomers opened this issue Apr 15, 2017 · 0 comments
Closed

tests should protect concurrent access to signal handlers #578

asomers opened this issue Apr 15, 2017 · 0 comments
Assignees
@asomers

Comments

@asomers
Copy link
Member

asomers commented Apr 15, 2017

tests/sys/test_aio.rs has two separate tests that install handlers for SIGUSR2. This was probably the root cause of #529 . It should've been fixed by 0e3ef36, but we still sometimes see related failures. Instead of globally restricting the thread count to 1, those tests should use a mutex to protect access to signal handlers. So far, there are no tests outside of that file that also use SIGUSR2.
@asomers asomers self-assigned this Apr 15, 2017
asomers added a commit to asomers/nix that referenced this issue Apr 15, 2017
@asomers
tests should protect concurrent access to signal handlers
944bf2b 
Adds a mutex to protect access to SIGUSR2 signal handlers by the AIO
tests.

Fixes nix-rust#578
@asomers asomers mentioned this issue Apr 15, 2017
Merged
asomers added a commit to asomers/nix that referenced this issue Apr 15, 2017
@asomers
tests should protect concurrent access to signal handlers
46ed256 
Adds a mutex to protect access to SIGUSR2 signal handlers by the AIO
tests.

Fixes nix-rust#578
@Susurrus Susurrus mentioned this issue Apr 15, 2017
Closed
bors bot added a commit that referenced this issue Apr 16, 2017
@bors
Merge #579
8c47de4 
579: tests should protect concurrent access to signal handlers r=asomers
Adds a mutex to protect access to SIGUSR2 signal handlers by the AIO
tests.

Fixes #578
@asomers asomers closed this as completed Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asomers asomers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asomers