Skip to content

Commit 95bedfd

Browse files
authored
refactor: remove EventFd::defuse() and EventFd::arm() (#2452)
* fix: remove Eventfd::arm() and defuse() * chore: changelog entry
1 parent 8d9c880 commit 95bedfd

File tree

3 files changed

+2
-15
lines changed

3 files changed

+2
-15
lines changed

changelog/2452.removed.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
`EventFd::defuse()` is removed because it does nothing, `EventFd::arm()` is also removed for symmetry reasons.

src/sys/epoll.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ impl EpollEvent {
8888
/// epoll.add(&eventfd, EpollEvent::new(EpollFlags::EPOLLIN,DATA))?;
8989
///
9090
/// // Arm eventfd & Time wait
91-
/// eventfd.arm()?;
91+
/// eventfd.write(1)?;
9292
/// let now = Instant::now();
9393
///
9494
/// // Wait on event

src/sys/eventfd.rs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -58,20 +58,6 @@ impl EventFd {
5858
Self::from_value_and_flags(init_val, EfdFlags::empty())
5959
}
6060

61-
/// Arms `self`, a following call to `poll`, `select` or `epoll` will return immediately.
62-
///
63-
/// [`EventFd::write`] with `1`.
64-
pub fn arm(&self) -> Result<usize> {
65-
self.write(1)
66-
}
67-
68-
/// Defuses `self`, a following call to `poll`, `select` or `epoll` will block.
69-
///
70-
/// [`EventFd::write`] with `0`.
71-
pub fn defuse(&self) -> Result<usize> {
72-
self.write(0)
73-
}
74-
7561
/// Enqueues `value` triggers, i.e., adds the integer value supplied in `value`
7662
/// to the counter.
7763
///

0 commit comments

Comments
 (0)