Skip to content

Commit

Permalink
Merge #1043
Browse files Browse the repository at this point in the history
1043: Uncomment to_std and from_std methods for IpAddr r=asomers a=rabbott99

These were commented out in 2b60633, apparently because `std::net::IpAddr` had been removed from the standard library. However, `IpAddr` has since been re-added to the standard library (rust-lang/rust#23711) and stabilized (rust-lang/rust#31438), so it seems there is no reason to keep them commented out.

Co-authored-by: rabbott99 <rabbott4927@gmail.com>
  • Loading branch information
bors[bot] and rabbott99 committed Apr 11, 2019
2 parents 0059ddf + 9f7deb1 commit 179bcb5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
([#969](https://github.com/nix-rust/nix/pull/969))
- Add several errno constants from OpenBSD 6.2
([#1036](https://github.com/nix-rust/nix/pull/1036))
- Added `from_std` and `to_std` methods for `sys::socket::IpAddr`
([#1043](https://github.com/nix-rust/nix/pull/1043))

### Changed
- `PollFd` event flags renamed to `PollFlags` ([#1024](https://github.com/nix-rust/nix/pull/1024/))
Expand Down
3 changes: 1 addition & 2 deletions src/sys/socket/addr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -418,20 +418,19 @@ impl IpAddr {
IpAddr::V6(Ipv6Addr::new(a, b, c, d, e, f, g, h))
}

/*
pub fn from_std(std: &net::IpAddr) -> IpAddr {
match *std {
net::IpAddr::V4(ref std) => IpAddr::V4(Ipv4Addr::from_std(std)),
net::IpAddr::V6(ref std) => IpAddr::V6(Ipv6Addr::from_std(std)),
}
}

pub fn to_std(&self) -> net::IpAddr {
match *self {
IpAddr::V4(ref ip) => net::IpAddr::V4(ip.to_std()),
IpAddr::V6(ref ip) => net::IpAddr::V6(ip.to_std()),
}
}
*/
}

impl fmt::Display for IpAddr {
Expand Down

0 comments on commit 179bcb5

Please sign in to comment.