This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
CI coverage for Mac OS #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaronjanse the thing is, I support the overall idea as it's an easy win, but in case we ever stumble upon macos issues, I won't be able to help as soon as it goes beyond helping people in the issue tracker (and tbh I'm not very interested either - no offense). Unless you want to/can help out in these cases, I'd suggest we somehow state in the README that there's no realiable macos support. |
|
@peterbecich would you mind stating in the README, that we cannot guarantee full macos support currently (or: only on a best-effort basis)? Other than that, it seems good to go. |
peterbecich
force-pushed
the
macos-ci-coverage
branch
from
494c9e9
to
69d5057
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
https://github.com/peterbecich/rnix-lsp/actions/runs/1401716756
Further context
#60