expose withNodeJs option to pass to neovim wrapper #1198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the neovim wrapper to be built with node plugin support by specifying it in the nixvim config. I confirmed that it is present with
:checkhealth
and that I could load something via a runtimepathrplugin/node
folder.:checkhealth
output:Setting this new option changes the command-line lua argument passed by the neovim wrapper such that
vim.g.loaded_node_provider=0
is not passed meaning provider will loaded, and also now thevim.g.node_host_prog
gets set. The difference looks like this if you look at ps outout:withNodeJs
option set to true:Without the option set:
Note that the
nix flake check
tests fail for me with the following error:But I think this has nothing to do with my change. I'm happy to run tests again, if there is something I'm missing here.
If this PR is accepted then probably the other neovim provider option should be exposed (perl, python, ruby, etc) but I don't have the means to test those atm so didn't include them.