plugins/none-ls: fix withArgs type, syntax #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously null or string, but was changed to null or Lua in nix-community#1169. Internally, `withArgs` is expected to be a string, but `mkNullOrLua` applies `mkRaw`, leading to a type error when generating the output, as it is attempting to interpolate a set rather than a string. Tested locally, and verified that it fixes my setup.
robhanlon22
changed the title
traxys
requested changes
Mar 2, 2024
| @@ -331,7 +331,7 @@ in { | |||
| (source: _: | |||
| { | |||
| enable = mkEnableOption "the ${source} ${sourceType} source for none-ls"; | |||
| withArgs = helpers.mkNullOrLua '' | |||
There was a problem hiding this comment.
the right type should be helpers.mkNullOrOption helpers.nivimTypes.strLua! Sorry for the issue.
There was a problem hiding this comment.
So the type is a "lua string" but we are not converting it to raw right ?
There was a problem hiding this comment.
exactly, we pass it directly. We should improve it to take arbitrary lua values with a toLuaObject, but we can do that later.
|
@traxys @GaetanLepage comments addressed! |
traxys
requested changes
Mar 2, 2024
|
@traxys d'oh, my bad. Updated |
traxys
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously null or string, but was changed to null or Lua in #1169. Internally,
withArgsis expected to be a string, butmkNullOrLuaappliesmkRaw, leading to a type error when generating the output, as it is attempting to interpolate a set rather than a string.Additionally, there was an errant extra } when interpolating the args, which led to a broken init.lua.
Tested locally, and verified that it fixes my setup.