-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cancelling the popovers by clicking away #129
base: master
Are you sure you want to change the base?
Conversation
Sorry for the conflicts, but I fixed 2 bugs on PR #136 |
82e6366
to
0819012
Compare
@niuware done. |
For the link popover the behavior is correct but for the media one the cursor goes back to the beginning of the editor whilst when clicking the ✔️ button it moves the cursor to the end of the editor. The latter would be the expected behavior as for now. |
…t/mui-rte into feature/popover-click-away
…t/mui-rte into feature/popover-click-away
@niuware I've merged the latest |
@niuware could you review this again? |
@niuware could you check this again? |
Hi @steurt, I haven't merged this one yet because of this unexpected behavior #129 (comment) . You can reproduce this by adding an image, then click on the image to edit it and close the popover by clicking away. You will notice the cursor goes back to the beginning of the editor instead of going to the end. |
@niuware thank you for the feedback and the reproduction steps. I'll check it out and make sure it works properly. |
Currently the popovers can only be closed by either confirming or emptying the value. I find that I'm missing the (default) click away behaviour of the popovers, which acts as a cancel. Therefore I've added it. I think this improves the user experience of the popovers.