Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cancelling the popovers by clicking away #129

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

steurt
Copy link
Contributor

@steurt steurt commented Jun 3, 2020

Currently the popovers can only be closed by either confirming or emptying the value. I find that I'm missing the (default) click away behaviour of the popovers, which acts as a cancel. Therefore I've added it. I think this improves the user experience of the popovers.

@steurt steurt changed the title Allow to cancel the popovers by clicking away Allow cancelling the popovers by clicking away Jun 3, 2020
@niuware niuware self-requested a review June 9, 2020 02:50
@niuware
Copy link
Owner

niuware commented Jun 9, 2020

Sorry for the conflicts, but I fixed 2 bugs on PR #136
Can you rebase and update your changes?

@steurt steurt force-pushed the feature/popover-click-away branch from 82e6366 to 0819012 Compare June 9, 2020 06:13
@steurt
Copy link
Contributor Author

steurt commented Jun 9, 2020

@niuware done.

@niuware
Copy link
Owner

niuware commented Jun 12, 2020

For the link popover the behavior is correct but for the media one the cursor goes back to the beginning of the editor whilst when clicking the ✔️ button it moves the cursor to the end of the editor. The latter would be the expected behavior as for now.

@steurt
Copy link
Contributor Author

steurt commented Jun 28, 2020

@niuware I've merged the latest master changes into the branch of this pull request. This fixes the issue, now for the media popover the cursor behaves as desired when clicking away.

@steurt
Copy link
Contributor Author

steurt commented Jul 22, 2020

@niuware could you review this again?

@steurt
Copy link
Contributor Author

steurt commented Nov 8, 2020

@niuware could you check this again?

@niuware
Copy link
Owner

niuware commented Nov 11, 2020

Hi @steurt, I haven't merged this one yet because of this unexpected behavior #129 (comment) . You can reproduce this by adding an image, then click on the image to edit it and close the popover by clicking away. You will notice the cursor goes back to the beginning of the editor instead of going to the end.

@steurt
Copy link
Contributor Author

steurt commented Nov 11, 2020

@niuware thank you for the feedback and the reproduction steps. I'll check it out and make sure it works properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants