Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Typo in log_variational_posterior computation #2

Open
shishir13sharma opened this issue Mar 25, 2019 · 0 comments
Open

Typo in log_variational_posterior computation #2

shishir13sharma opened this issue Mar 25, 2019 · 0 comments

Comments

@shishir13sharma
Copy link
Contributor

The return statement should be:
return self.l1.log_variational_posterior
+ self.l2.log_variational_posterior
+ self.l3.log_variational_posterior
instead of the current :
return self.l1.log_variational_posterior
+ self.l2.log_variational_posterior
+ self.l2.log_variational_posterior
Currently, the log posterior of l2 is being counted twice and the log posterior of l3 is not being taken into account at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant