Update: SDK to support Jitpack #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Skip issue time validation or change the allowed time skew Allows to completely disable ID tokens issue time validation, or change the default of 10 minutes to a custom allowed time skew in seconds. * Update documentation to change the allowed id token time skew --------- Co-authored-by: Tim Klingeleers <Mardaneus86@users.noreply.github.com>
Uri.getScheme() may return null if no scheme is contained in the given string. This could cause a crash during id token validation when this was the case for the contained "iss" claim. Co-authored-by: Florian Märkl <info@florianmaerkl.de>
Co-authored-by: Luca Figoli <luca.figoli@consultant.aruba.it>
Co-authored-by: Maksim <taikonavt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
AppAuth-Androidproject, focusing on documentation improvements, configuration adjustments, and build script updates. The most important changes are summarized below:Documentation Updates:
README.mdto replace Maven Central download links with Jitpack and added new configuration options forAppAuthConfiguration. [1] [2] [3]Configuration Changes:
mConfigHashinitialization earlier in thereadConfigurationmethod inConfiguration.java. [1] [2]mSkipIssueTimeValidationandmAllowedIssueTimeSkewinAppAuthConfigurationto allow more flexible token validation.Build Script Updates:
gradle-wrapper.propertiesto use Gradle 8.11.1 and madegradlewscript more POSIX-compliant. [1] [2] [3] [4]gradlew.batscript and added SPDX license identifier. [1] [2] [3]Lint and Packaging Options:
android-common.gradle. [1] [2]JDK Configuration:
jitpack.ymlto specify the use of OpenJDK 17 for builds.