fixes

Author: sarthak

modules/metadata-service/ec2.tf

@@ -161,7 +161,7 @@ resource "aws_lb" "alb" {
   load_balancer_type = "application"
   idle_timeout       = 180 # 3 minutes
   subnets            = [var.subnet1_id, var.subnet2_id]
-  security_groups    = [aws_security_group.metadata_alb_security_group[0].id]
+  security_groups    = [aws_security_group.metadata_alb_security_group.id]
 
   tags = var.standard_tags
 }
@@ -208,24 +208,24 @@ resource "aws_lb_target_group" "alb_db_migrate" {
 }
 
 resource "aws_lb_listener" "alb_main" {
-  load_balancer_arn = aws_lb.alb[0].arn
+  load_balancer_arn = aws_lb.alb.arn
   port              = "80"
   protocol          = "HTTP"
 
   default_action {
     type             = "forward"
-    target_group_arn = aws_lb_target_group.alb_main[0].arn
+    target_group_arn = aws_lb_target_group.alb_main.arn
   }
 }
 
 resource "aws_lb_listener" "alb_db_migrate" {
-  load_balancer_arn = aws_lb.alb[0].arn
+  load_balancer_arn = aws_lb.alb.arn
   port              = "8082"
   protocol          = "HTTP"
 
   default_action {
     type             = "forward"
-    target_group_arn = aws_lb_target_group.alb_db_migrate[0].arn
+    target_group_arn = aws_lb_target_group.alb_db_migrate.arn
   }
 }
 
@@ -256,8 +256,8 @@ resource "aws_lb_target_group" "apigw_metadata" {
 }
 
 resource "aws_lb_target_group_attachment" "apigw_metadata" {
-  target_group_arn = aws_lb_target_group.apigw_metadata[0].arn
-  target_id        = aws_lb.alb[0].arn
+  target_group_arn = aws_lb_target_group.apigw_metadata.arn
+  target_id        = aws_lb.alb.arn
 }
 
 resource "aws_lb_target_group" "apigw_db_migrate" {
@@ -279,28 +279,28 @@ resource "aws_lb_target_group" "apigw_db_migrate" {
 }
 
 resource "aws_lb_target_group_attachment" "apigw_db_migrate" {
-  target_group_arn = aws_lb_target_group.apigw_db_migrate[0].arn
-  target_id        = aws_lb.alb[0].arn
+  target_group_arn = aws_lb_target_group.apigw_db_migrate.arn
+  target_id        = aws_lb.alb.arn
 }
 
 resource "aws_lb_listener" "apigw_metadata" {
-  load_balancer_arn = aws_lb.apigw_nlb[0].arn
+  load_balancer_arn = aws_lb.apigw_nlb.arn
   port              = "80"
   protocol          = "TCP"
 
   default_action {
     type             = "forward"
-    target_group_arn = aws_lb_target_group.apigw_metadata[0].arn
+    target_group_arn = aws_lb_target_group.apigw_metadata.arn
   }
 }
 
 resource "aws_lb_listener" "apigw_db_migrate" {
-  load_balancer_arn = aws_lb.apigw_nlb[0].arn
+  load_balancer_arn = aws_lb.apigw_nlb.arn
   port              = "8082"
   protocol          = "TCP"
 
   default_action {
     type             = "forward"
-    target_group_arn = aws_lb_target_group.apigw_db_migrate[0].arn
+    target_group_arn = aws_lb_target_group.apigw_db_migrate.arn
   }
 }

modules/metadata-service/lambda.tf

@@ -126,7 +126,7 @@ resource "aws_lambda_function" "db_migrate_lambda" {
 
   environment {
     variables = {
-      MD_LB_ADDRESS = "http://${aws_lb.this.dns_name}:8082"
+      MD_LB_ADDRESS = "http://${aws_lb.alb.dns_name}:8082"
     }
   }
 

modules/metadata-service/outputs.tf

@@ -1,5 +1,5 @@
 output "METAFLOW_SERVICE_INTERNAL_URL" {
-  value       = "http://${aws_lb.this.dns_name}/"
+  value       = "http://${aws_lb.alb.dns_name}/"
   description = "URL for Metadata Service (Accessible in VPC)"
 }
 
@@ -34,6 +34,6 @@ output "metadata_svc_ecs_task_role_arn" {
 }
 
 output "network_load_balancer_dns_name" {
-  value       = aws_lb.this.dns_name
+  value       = aws_lb.alb.dns_name
   description = "The DNS addressable name for the Network Load Balancer that accepts requests and forwards them to our Fargate MetaData service instance(s)"
 }