Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: First implementation of loading and applying ITK displacements fields #42

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

oesteban
Copy link
Collaborator

@oesteban oesteban commented Oct 30, 2019

Adds a simple loader and some new tests, which include several image orientations.

@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #42 into master will increase coverage by 0.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   98.24%   98.67%   +0.42%     
==========================================
  Files          10       10              
  Lines         742      756      +14     
  Branches       98       98              
==========================================
+ Hits          729      746      +17     
+ Misses          7        6       -1     
+ Partials        6        4       -2
Flag Coverage Δ
#unittests 98.54% <100%> (+0.29%) ⬆️
Impacted Files Coverage Δ
nitransforms/io/itk.py 100% <100%> (ø) ⬆️
nitransforms/nonlinear.py 100% <100%> (+13.63%) ⬆️
nitransforms/base.py 99.2% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ce632...96280eb. Read the comment docs.

@oesteban oesteban force-pushed the fix/32 branch 2 times, most recently from 129d9e3 to 68ec96d Compare October 30, 2019 23:32
@oesteban oesteban marked this pull request as ready for review October 30, 2019 23:51
@oesteban oesteban requested a review from mgxd October 30, 2019 23:51
Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good!

nitransforms/tests/test_nonlinear.py Show resolved Hide resolved
nitransforms/tests/test_nonlinear.py Show resolved Hide resolved
@mgxd mgxd merged commit 77a3a3b into nipy:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants