Skip to content

Conversation

jhlegarreta
Copy link

@jhlegarreta jhlegarreta commented Jul 21, 2025

Execute slowest tests on schedule.

Fixes #229.

@jhlegarreta
Copy link
Author

@effigies I am not happy with this duplication, but did not find a better way to try to do this:
https://github.com/nipy/nitransforms/pull/258/files#diff-8a1944567ec5d9e12aaaac28489c47e6567e13b58d861815379f9b8d3aeb2623R115-R159

Copy link
Collaborator

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped 3.9 in #259 because I believe version 25.x series should drop it (and backward compatibility of #256 was really hard).

That all said, what takes the most time here is CircleCI's tests. Perhaps we can drop all the docker shebang which substantially adds to the build.

@jhlegarreta jhlegarreta force-pushed the mnt/mark-tests-slow branch from 43b21f7 to 8a2071a Compare July 22, 2025 23:34
@jhlegarreta
Copy link
Author

That all said, what takes the most time here is CircleCI's tests. Perhaps we can drop all the docker shebang which substantially adds to the build.

Please, feel free to take over; I thought that issue #229 referred to Python testing purely, so did not have a look at what are other bottlenecks. I am not sure the current approach is working well either, since I do not see the GitHub checks taking place on the commit event.

Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.74%. Comparing base (0c2ad9f) to head (34e33e7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files          16       16           
  Lines        1994     1994           
  Branches      267      267           
=======================================
  Hits         1929     1929           
  Misses         41       41           
  Partials       24       24           
Flag Coverage Δ
unittests 96.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jhlegarreta and others added 2 commits September 5, 2025 11:01
Execute slowest tests on schedule.

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Drop 3.9 from tested Python version matrix.

Co-authored-by: Oscar Esteban <code@oscaresteban.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark tests as slow to enable separate running
3 participants