Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Loosen dependencies #164

Merged
merged 3 commits into from
Jul 10, 2023
Merged

MAINT: Loosen dependencies #164

merged 3 commits into from
Jul 10, 2023

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented May 2, 2022

No description provided.

@mgxd mgxd requested a review from oesteban May 2, 2022 19:36
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (951119e) 98.59% compared to head (46cdedc) 98.54%.

❗ Current head 46cdedc differs from pull request most recent head 03b25e4. Consider uploading reports for the commit 03b25e4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   98.59%   98.54%   -0.05%     
==========================================
  Files          13       13              
  Lines        1279     1169     -110     
  Branches      184      184              
==========================================
- Hits         1261     1152     -109     
  Misses         10       10              
+ Partials        8        7       -1     
Flag Coverage Δ
travis ?
unittests 98.54% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oesteban
Copy link
Collaborator

Hi @mgxd, sorry for my slow coming back to this. Could you remind me why this is necessary? It doesn't seem like a good idea to loosen up restrictions if the versions installed of numpy or scipy are not supported by the Python version.

@effigies
Copy link
Member

Just looking at this... You really don't want a base library to have complicated install-time dependencies. Just declare a minimum version and move on. I suspect this was used when we were using python setup.py instead of pip, and the dependency resolution was terrible and did not respect python_requires.

@oesteban
Copy link
Collaborator

We probably want to update pins though, before going ahead, right?

@mgxd
Copy link
Member Author

mgxd commented Jul 10, 2023

I think it should be fine, I'll rebase and trigger tests again

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. We could also tweak these, or I can open a new PR after this is in.

.readthedocs.yaml Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
@effigies
Copy link
Member

@oesteban Can you make me an admin on ReadTheDocs? I want to set up PR builds.

@oesteban
Copy link
Collaborator

@oesteban Can you make me an admin on ReadTheDocs? I want to set up PR builds.

done!

@effigies
Copy link
Member

Sorry, Mathias. I forgot about dropping 3.7 in CI. Looks like we haven't been testing 3.10 or 3.11 either. Happy to take this over if you don't want to babysit the CI loops.

@mgxd
Copy link
Member Author

mgxd commented Jul 10, 2023

Sure, I think this can be merged so you can just build off master

@effigies
Copy link
Member

Sounds good.

@effigies effigies merged commit 2009ceb into nipy:master Jul 10, 2023
@mgxd mgxd deleted the maint/loosen-deps branch July 10, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants