-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Loosen dependencies #164
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 98.59% 98.54% -0.05%
==========================================
Files 13 13
Lines 1279 1169 -110
Branches 184 184
==========================================
- Hits 1261 1152 -109
Misses 10 10
+ Partials 8 7 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @mgxd, sorry for my slow coming back to this. Could you remind me why this is necessary? It doesn't seem like a good idea to loosen up restrictions if the versions installed of numpy or scipy are not supported by the Python version. |
Just looking at this... You really don't want a base library to have complicated install-time dependencies. Just declare a minimum version and move on. I suspect this was used when we were using |
We probably want to update pins though, before going ahead, right? |
I think it should be fine, I'll rebase and trigger tests again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me. We could also tweak these, or I can open a new PR after this is in.
@oesteban Can you make me an admin on ReadTheDocs? I want to set up PR builds. |
done! |
Sorry, Mathias. I forgot about dropping 3.7 in CI. Looks like we haven't been testing 3.10 or 3.11 either. Happy to take this over if you don't want to babysit the CI loops. |
Sure, I think this can be merged so you can just build off master |
Sounds good. |
No description provided.