-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STY: Apply ruff/flake8-comprehensions rules (C4) #3680
Open
DimitriPapadopoulos
wants to merge
7
commits into
nipy:master
Choose a base branch
from
DimitriPapadopoulos:C4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C400 Unnecessary generator (rewrite as a `list` comprehension)
C409 Unnecessary `list` literal passed to `tuple()` (rewrite as a `tuple` literal)
C414 Unnecessary `list` call
C416 Unnecessary `list` comprehension (rewrite using `list()`)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3680 +/- ##
===========================================
- Coverage 70.83% 39.49% -31.34%
===========================================
Files 1276 1276
Lines 59314 59314
Branches 9824 9809 -15
===========================================
- Hits 42013 23427 -18586
- Misses 16125 35741 +19616
+ Partials 1176 146 -1030 ☔ View full report in Codecov by Sentry. |
C419 Unnecessary list comprehension
DimitriPapadopoulos
force-pushed
the
C4
branch
from
September 22, 2024 13:38
8b4c8ef
to
f81392c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apply flake8-comprehensions (C4) rules, except: