Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Apply ruff/flake8-comprehensions rules (C4) #3680

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

DimitriPapadopoulos
Copy link
Contributor

Summary

Apply flake8-comprehensions (C4) rules, except:

  • C408 (15011 errors!)

C400 Unnecessary generator (rewrite as a `list` comprehension)
C409 Unnecessary `list` literal passed to `tuple()` (rewrite as a `tuple` literal)
C416 Unnecessary `list` comprehension (rewrite using `list()`)
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 39.49%. Comparing base (4d1352a) to head (f81392c).

Files with missing lines Patch % Lines
nipype/interfaces/io.py 0.00% 6 Missing ⚠️
nipype/interfaces/diffusion_toolkit/odf.py 0.00% 4 Missing ⚠️
nipype/interfaces/cmtk/cmtk.py 0.00% 2 Missing ⚠️
nipype/interfaces/spm/model.py 0.00% 2 Missing ⚠️
nipype/pipeline/engine/nodes.py 0.00% 2 Missing ⚠️
nipype/pipeline/engine/utils.py 0.00% 2 Missing ⚠️
nipype/algorithms/modelgen.py 0.00% 0 Missing and 1 partial ⚠️
nipype/algorithms/tests/test_CompCor.py 0.00% 1 Missing ⚠️
nipype/interfaces/ants/segmentation.py 0.00% 1 Missing ⚠️
nipype/interfaces/base/core.py 0.00% 1 Missing ⚠️
... and 8 more

❗ There is a different number of reports uploaded between BASE (4d1352a) and HEAD (f81392c). Click for more details.

HEAD has 65 uploads less than BASE
Flag BASE (4d1352a) HEAD (f81392c)
69 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3680       +/-   ##
===========================================
- Coverage   70.83%   39.49%   -31.34%     
===========================================
  Files        1276     1276               
  Lines       59314    59314               
  Branches     9824     9809       -15     
===========================================
- Hits        42013    23427    -18586     
- Misses      16125    35741    +19616     
+ Partials     1176      146     -1030     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant