Skip to content

FIX: Incorrect extension identified when checking File traits #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Aug 5, 2019

Rewritten the validation of filename extensions, as it was incorrectly
interpreting the extension.

Fixes #2984.

Rewritten the validation of filename extensions, as it was incorrectly
interpreting the extension.

Fixes nipy#2984.
@oesteban oesteban merged commit e788059 into nipy:master Aug 5, 2019
@oesteban oesteban deleted the fix/2984 branch August 5, 2019 19:41
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #2987 into master will decrease coverage by 3.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2987      +/-   ##
==========================================
- Coverage    67.6%   64.24%   -3.36%     
==========================================
  Files         344      342       -2     
  Lines       43802    43747      -55     
  Branches     5478     5475       -3     
==========================================
- Hits        29611    28106    -1505     
- Misses      13475    14553    +1078     
- Partials      716     1088     +372
Flag Coverage Δ
#smoketests ?
#unittests 64.24% <100%> (-0.8%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/base/traits_extension.py 89.52% <100%> (-5.24%) ⬇️
nipype/interfaces/nilearn.py 40% <0%> (-56.67%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/interfaces/freesurfer/base.py 50% <0%> (-30.51%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-29.86%) ⬇️
nipype/algorithms/rapidart.py 35% <0%> (-29.42%) ⬇️
nipype/interfaces/spm/base.py 57.94% <0%> (-29.14%) ⬇️
nipype/utils/provenance.py 55.73% <0%> (-28.35%) ⬇️
nipype/interfaces/fsl/model.py 55.26% <0%> (-25.35%) ⬇️
nipype/testing/fixtures.py 77.33% <0%> (-21.34%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865adc9...be28002. Read the comment docs.

@effigies effigies added this to the 1.2.1 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect extension identified when checking the extensions metadata of File traits
2 participants