Skip to content

Fix: Extract unit information from image header in CompCor #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2018

Conversation

eort
Copy link
Contributor

@eort eort commented Feb 22, 2018

Fixes #2456 .

Changes proposed in this pull request

  • extract unit information from image header, rather than from image directly

@effigies
Copy link
Member

LGTM

@effigies effigies added this to the 1.0.1 milestone Feb 22, 2018
@effigies effigies merged commit cc750f4 into nipy:master Feb 22, 2018
@codecov-io
Copy link

codecov-io commented Feb 22, 2018

Codecov Report

Merging #2458 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2458   +/-   ##
=======================================
  Coverage   66.62%   66.62%           
=======================================
  Files         328      328           
  Lines       42508    42508           
  Branches     5280     5280           
=======================================
  Hits        28321    28321           
  Misses      13505    13505           
  Partials      682      682
Flag Coverage Δ
#smoketests 50.73% <0%> (ø) ⬆️
#unittests 63.95% <0%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/algorithms/confounds.py 67.31% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d0159...f3efbd9. Read the comment docs.

@eort eort deleted the CompCorFix branch February 22, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants