ENH Allow input weight for AFNI's volreg. #2396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a clean PR, based on the suggestions in nipy#2155.
|
If it helps, you can have a look at these changes: master...effigies:afni_volreg_inweight I was attempting to push to your branch yesterday. I haven't updated them to push onto this PR because I don't want to clog the Circle queue just now. Feel free to reset to that branch, or pull onto your old branch, or just use them to compare your changes. |
|
I just needed have the required dependencies to run the tests. Feel free to make whatever changes you think should be made - or merge your version. |
|
I think this is good to go. Anybody up for a review? |
|
It looks good to me. Thanks a lot for your work @effigies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean PR, based on the suggestions in #2155.
I'm having some issues with running
make check-before-commit. I will look into it more soon.