FIX: Build filter_basis of correct size #2138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently coded, an empty filter basis that then has non-steady-state outlier regressors added in does not have the correct size. It is supposed to have the same number of rows as the confound file, but instead is a square matrix (same number of rows as outliers).
An empty filter basis is possible for short BOLD series, which I suspect will only come up in tests, but it is coming up in our tests.
Changes proposed in this pull request
Follow-up to #2107, #2122, #2136.