Skip to content

[ENH] Added afni.FWHMx interface #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 12, 2016
Merged

Conversation

oesteban
Copy link
Contributor

No description provided.

return super(FWHMx, self)._format_arg(name, trait_spec, value)

def _run_interface(self, runtime):
if platform == 'darwin':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an AFNI wide or FWHM specific issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only experienced it with the FWHMx interface, I don't know if it's for some other. Definitely not all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like despike also has the problem. Maybe worth setting for all afni interfaces.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@oesteban
Copy link
Contributor Author

This is ready to go. I have checked that tests pass (seems like Travis is queueing today)

@chrisgorgo
Copy link
Member

Are you planning to send the OSX fix a sseparate PR?

chrisgorgo added a commit that referenced this pull request Feb 12, 2016
[ENH] Added afni.FWHMx interface
@chrisgorgo chrisgorgo merged commit ccbbe56 into nipy:master Feb 12, 2016
@oesteban
Copy link
Contributor Author

It is included in this one since it is a minor change (added here https://github.com/nipy/nipype/pull/1361/files#diff-e0d822d271f09df14e2fa7444c9a4f3dR119)

@chrisgorgo
Copy link
Member

Thx - I somehow missed it.

@oesteban oesteban deleted the enh/AddAfniFWHM branch February 12, 2016 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants