Skip to content

ENH: Provides a Nipype wrapper for antsJointFusion #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2016
Merged

ENH: Provides a Nipype wrapper for antsJointFusion #1351

merged 2 commits into from
Feb 12, 2016

Conversation

jessicaforbes
Copy link
Contributor

No description provided.

@hjmjohnson
Copy link
Contributor

@jessicaforbes Can some of these patchsets be merged together. It appears that a new feature is added, and then many bug fixes to that new feature are put into place. There is no need to have a new feature and bug fixes to it. Just squash the bugs fixes into the initial release.

@jessicaforbes
Copy link
Contributor Author

@hjmjohnson They are squashed. Thanks Hans.



class AntsJointFusionOutputSpec(TraitedSpec):
out_label_fusion = File()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add exists=True

The required output file must exist to be a valid completion of AntsJointFusion, so
add this check to the file.
@chrisgorgo chrisgorgo merged commit 6b57949 into nipy:master Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants