Test check_depends

Author: effigies

nipype/utils/filemanip.py

@@ -457,7 +457,7 @@ def check_depends(targets, dependencies):
     deps = filename_to_list(dependencies)
     return all(map(os.path.exists, tgts)) and \
         min(map(os.path.getmtime, tgts)) > \
-        max(map(os.path.getmtime, deps), default=0)
+        max(list(map(os.path.getmtime, deps)) + [0])
 
 
 def save_json(filename, data):

nipype/utils/tests/test_filemanip.py

@@ -5,7 +5,9 @@
 from builtins import open
 
 import os
-from tempfile import mkstemp
+import time
+from tempfile import mkstemp, mkdtemp
+import shutil
 import warnings
 
 import pytest
@@ -15,6 +17,7 @@
                                 hash_rename, check_forhash,
                                 copyfile, copyfiles,
                                 filename_to_list, list_to_filename,
+                                check_depends,
                                 split_filename, get_related_files)
 
 import numpy as np
@@ -271,6 +274,41 @@ def test_list_to_filename(list, expected):
     assert x == expected
 
 
+def test_check_depends():
+    def touch(fname):
+        with open(fname, 'a'):
+            os.utime(fname, None)
+
+    tmpdir = mkdtemp()
+
+    dependencies = [os.path.join(tmpdir, str(i)) for i in range(3)]
+    targets = [os.path.join(tmpdir, str(i)) for i in range(3, 6)]
+
+    # Targets newer than dependencies
+    for dep in dependencies:
+        touch(dep)
+    time.sleep(1)
+    for tgt in targets:
+        touch(tgt)
+    assert check_depends(targets, dependencies)
+
+    # Targets older than newest dependency
+    time.sleep(1)
+    touch(dependencies[0])
+    assert not check_depends(targets, dependencies)
+
+    # Missing dependency
+    os.unlink(dependencies[0])
+    try:
+        check_depends(targets, dependencies)
+    except OSError as e:
+        pass
+    else:
+        assert False, "Should raise OSError on missing dependency"
+
+    shutil.rmtree(tmpdir)   
+
+
 def test_json():
     # Simple roundtrip test of json files, just a sanity check.
     adict = dict(a='one', c='three', b='two')