-
Notifications
You must be signed in to change notification settings - Fork 264
ENH: Add ndim to ArrayProxy and DataobjImage #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
==========================================
+ Coverage 88.86% 88.87% +<.01%
==========================================
Files 93 93
Lines 11378 11386 +8
Branches 1869 1869
==========================================
+ Hits 10111 10119 +8
Misses 930 930
Partials 337 337
Continue to review full report at Codecov.
|
@cancan101 Would you like to test that this provides the interface(s) you were asking for? |
@matthew-brett Up for a quick review? This is a pretty small change. |
Thanks - yes - it looks fine. The only question is whether it's really worth adding the code for the benefit of going from |
I agree it's trivial. The advantage of the addition to ArrayProxy is that now ndim exists regardless of how the image is created. It's just a least surprise sort of thing. Passing it though to the image itself is less obviously simplifying, but what #595 originally asked about, so I went ahead and included it. |
Then I'm fine with it, if you are ... |
Closes #595.