-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: blue/isort/flake8 → ruff #1289
Conversation
36876f9
to
e0f9772
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
- Coverage 92.26% 92.25% -0.02%
==========================================
Files 99 99
Lines 12472 12453 -19
Branches 2566 2555 -11
==========================================
- Hits 11507 11488 -19
Misses 642 642
Partials 323 323 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to update the tox environments:
Lines 138 to 161 in 1436a6e
[testenv:style] | |
description = Check our style guide | |
labels = check | |
deps = | |
flake8 | |
blue | |
# Broken extras, remove when fix is released | |
isort[colors]!=5.13.1 | |
skip_install = true | |
commands = | |
blue --check --diff --color nibabel | |
isort --check --diff --color nibabel | |
flake8 nibabel | |
[testenv:style-fix] | |
description = Auto-apply style guide to the extent possible | |
labels = pre-release | |
deps = | |
blue | |
isort | |
skip_install = true | |
commands = | |
blue nibabel | |
isort nibabel |
d5ddc8f
to
136ff23
Compare
Done. @effigies It's now ready for reviewing. |
e251260
to
98f3db5
Compare
98f3db5
to
045dbc1
Compare
1b32845
to
96846b0
Compare
Bumping ruff from 0.1.9 to 0.3.0 is unexpectedly intrusive - lots of change by |
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
a3efe03
to
02918ed
Compare
I think I have addressed all of them. Note that I rebased to fix a merge conflict. |
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Or not 😄 The quantity of changes pushes the GitHub web interface to its limits. I have a hard time navigating the comments. Still one to address, almost there. |
Enforce that in pyproject.toml instead of conf.py itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Fixes #1288 (comment).