Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: blue/isort/flake8 → ruff #1289

Merged
merged 32 commits into from
Apr 14, 2024
Merged

Conversation

DimitriPapadopoulos
Copy link
Contributor

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.25%. Comparing base (c445edd) to head (066431d).

Files Patch % Lines
nibabel/cmdline/diff.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
- Coverage   92.26%   92.25%   -0.02%     
==========================================
  Files          99       99              
  Lines       12472    12453      -19     
  Branches     2566     2555      -11     
==========================================
- Hits        11507    11488      -19     
  Misses        642      642              
  Partials      323      323              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update the tox environments:

nibabel/tox.ini

Lines 138 to 161 in 1436a6e

[testenv:style]
description = Check our style guide
labels = check
deps =
flake8
blue
# Broken extras, remove when fix is released
isort[colors]!=5.13.1
skip_install = true
commands =
blue --check --diff --color nibabel
isort --check --diff --color nibabel
flake8 nibabel
[testenv:style-fix]
description = Auto-apply style guide to the extent possible
labels = pre-release
deps =
blue
isort
skip_install = true
commands =
blue nibabel
isort nibabel

pyproject.toml Outdated Show resolved Hide resolved
@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Dec 26, 2023

Also need to update the tox environments:

Done.

@effigies It's now ready for reviewing.

@DimitriPapadopoulos
Copy link
Contributor Author

Bumping ruff from 0.1.9 to 0.3.0 is unexpectedly intrusive - lots of change by ruff format.

DimitriPapadopoulos and others added 8 commits March 29, 2024 14:46
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@DimitriPapadopoulos
Copy link
Contributor Author

I think I have addressed all of them. Note that I rebased to fix a merge conflict.

DimitriPapadopoulos and others added 13 commits March 29, 2024 14:53
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@DimitriPapadopoulos
Copy link
Contributor Author

Or not 😄

The quantity of changes pushes the GitHub web interface to its limits. I have a hard time navigating the comments.

Still one to address, almost there.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@effigies effigies merged commit a2e5dee into nipy:master Apr 14, 2024
50 of 52 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the blue_ruff branch April 15, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants