Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Add py312-dev-x64 environment #1267

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Conversation

effigies
Copy link
Member

@larsoner
Copy link
Contributor

Also need to add an entry to

include:
# Basic dependencies only
- os: ubuntu-latest
python-version: 3.8
dependencies: 'none'
# Absolute minimum dependencies
- os: ubuntu-latest
python-version: 3.8
dependencies: 'min'
exclude:
- os: ubuntu-latest
architecture: x86
- os: macos-latest
architecture: x86
- python-version: '3.12'
architecture: x86
, no?

I think a single run of NP2.0 is enough

@larsoner
Copy link
Contributor

Happy to push CI changes here if you want

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (adcc9ba) 92.19% compared to head (98489b5) 92.22%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1267      +/-   ##
==========================================
+ Coverage   92.19%   92.22%   +0.02%     
==========================================
  Files          99       99              
  Lines       12458    12454       -4     
  Branches     2559     2559              
==========================================
  Hits        11486    11486              
+ Misses        648      644       -4     
  Partials      324      324              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsoner
Copy link
Contributor

Seems to be failing as intended!

https://github.com/nipy/nibabel/actions/runs/6562773154/job/17825525527?pr=1267#step:7:62

E   AttributeError: `np.sctypes` was removed in the NumPy 2.0 release. . Did you mean: 'dtypes'?

@larsoner
Copy link
Contributor

@effigies feel free to merge and then we can see if #1250 fixes things

@effigies effigies merged commit 79c8b4b into nipy:master Oct 18, 2023
50 of 51 checks passed
@effigies effigies deleted the mnt/numpydev branch October 18, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants